提交 bfa64815 编写于 作者: J Jesse Glick

[FIXED JENKINS-14814] Truncate deeply nested upstream causes.

上级 b0278767
...@@ -34,6 +34,7 @@ import jenkins.model.Jenkins; ...@@ -34,6 +34,7 @@ import jenkins.model.Jenkins;
import org.kohsuke.stapler.export.Exported; import org.kohsuke.stapler.export.Exported;
import org.kohsuke.stapler.export.ExportedBean; import org.kohsuke.stapler.export.ExportedBean;
import com.thoughtworks.xstream.converters.UnmarshallingContext; import com.thoughtworks.xstream.converters.UnmarshallingContext;
import javax.annotation.Nonnull;
/** /**
* Cause object base class. This class hierarchy is used to keep track of why * Cause object base class. This class hierarchy is used to keep track of why
...@@ -100,6 +101,11 @@ public abstract class Cause { ...@@ -100,6 +101,11 @@ public abstract class Cause {
* A build is triggered by the completion of another build (AKA upstream build.) * A build is triggered by the completion of another build (AKA upstream build.)
*/ */
public static class UpstreamCause extends Cause { public static class UpstreamCause extends Cause {
/**
* Maximum depth of transitive upstream causes we want to record.
*/
private static final int MAX_DEPTH = 10;
private String upstreamProject, upstreamUrl; private String upstreamProject, upstreamUrl;
private int upstreamBuild; private int upstreamBuild;
/** /**
...@@ -107,7 +113,7 @@ public abstract class Cause { ...@@ -107,7 +113,7 @@ public abstract class Cause {
*/ */
@Deprecated @Deprecated
private transient Cause upstreamCause; private transient Cause upstreamCause;
private List<Cause> upstreamCauses; private @Nonnull List<Cause> upstreamCauses;
/** /**
* @deprecated since 2009-02-28 * @deprecated since 2009-02-28
...@@ -121,7 +127,33 @@ public abstract class Cause { ...@@ -121,7 +127,33 @@ public abstract class Cause {
upstreamBuild = up.getNumber(); upstreamBuild = up.getNumber();
upstreamProject = up.getParent().getFullName(); upstreamProject = up.getParent().getFullName();
upstreamUrl = up.getParent().getUrl(); upstreamUrl = up.getParent().getUrl();
upstreamCauses = new ArrayList<Cause>(up.getCauses()); upstreamCauses = new ArrayList<Cause>();
for (Cause c : up.getCauses()) {
upstreamCauses.add(trim(c, MAX_DEPTH));
}
}
private UpstreamCause(String upstreamProject, int upstreamBuild, String upstreamUrl, @Nonnull List<Cause> upstreamCauses) {
this.upstreamProject = upstreamProject;
this.upstreamBuild = upstreamBuild;
this.upstreamUrl = upstreamUrl;
this.upstreamCauses = upstreamCauses;
}
private @Nonnull Cause trim(@Nonnull Cause c, int depth) {
if (!(c instanceof UpstreamCause)) {
return c;
}
UpstreamCause uc = (UpstreamCause) c;
List<Cause> cs = new ArrayList<Cause>();
if (depth > 0) {
for (Cause c2 : uc.upstreamCauses) {
cs.add(trim(c2, depth - 1));
}
} else {
cs.add(new DeeplyNestedUpstreamCause());
}
return new UpstreamCause(uc.upstreamProject, uc.upstreamBuild, uc.upstreamUrl, cs);
} }
/** /**
...@@ -167,6 +199,10 @@ public abstract class Cause { ...@@ -167,6 +199,10 @@ public abstract class Cause {
); );
} }
@Override public String toString() {
return upstreamUrl + upstreamBuild + upstreamCauses;
}
public static class ConverterImpl extends XStream2.PassthruConverter<UpstreamCause> { public static class ConverterImpl extends XStream2.PassthruConverter<UpstreamCause> {
public ConverterImpl(XStream2 xstream) { super(xstream); } public ConverterImpl(XStream2 xstream) { super(xstream); }
@Override protected void callback(UpstreamCause uc, UnmarshallingContext context) { @Override protected void callback(UpstreamCause uc, UnmarshallingContext context) {
...@@ -178,6 +214,16 @@ public abstract class Cause { ...@@ -178,6 +214,16 @@ public abstract class Cause {
} }
} }
} }
public static class DeeplyNestedUpstreamCause extends Cause {
@Override public String getShortDescription() {
return "(deeply nested causes)";
}
@Override public String toString() {
return "JENKINS-14814";
}
}
} }
/** /**
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册