提交 b0e90ee0 编写于 作者: H Himangi Saraogi 提交者: Greg Kroah-Hartman

staging: wlags49_h2: Fix use of skb after netif_rx

This patch moves a call to netif_rx(skb) after a subsequent reference to
skb, because netif_rx may call kfree_skb via enqueue_to_backlog on its
argument.

This was found using the following semantic match.

// <smpl>
@@
expression skb, e,e1;
@@

(
 netif_rx(skb);
|
 netif_rx_ni(skb);
)
  ... when != skb = e
(
  skb = e1
|
* skb
)
// </smpl>
Signed-off-by: NHimangi Saraogi <himangi774@gmail.com>
Acked-by: NJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
上级 a9a4d8ca
......@@ -888,8 +888,6 @@ int wl_rx(struct net_device *dev)
GET_PACKET(skb->dev, skb, pktlen);
if (status == HCF_SUCCESS) {
netif_rx(skb);
if (port == 0) {
lp->stats.rx_packets++;
lp->stats.rx_bytes += pktlen;
......@@ -918,6 +916,7 @@ int wl_rx(struct net_device *dev)
}
#endif /* WIRELESS_SPY */
#endif /* WIRELESS_EXT */
netif_rx(skb);
} else {
DBG_ERROR(DbgInfo,
"Rx request to card FAILED\n");
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册