Minor changes from pr comments

contracts/eoslib/eosc.dox

@@ -6,9 +6,10 @@
   @section intro Introduction to EOSC
   
   `eosc` is a command line tool that interfaces with the REST api exposed by @ref eosd. In order to use `eosc` you will need to
-  have a local copy of `eosd` running and configured to load the 'eos::chain_api_plugin'. Currently, `eosc` does not
-  sign transactions, so in order for these instructions to work, `eosd` needs to be run with --skip-transaction-signatures.
+  have a local copy of `eosd` running and configured to load the 'eos::chain_api_plugin'.
 
+  As an easy way for developers to test functionality without dealing with keys, `eosd` can be run so that
+  Transaction signatures are not required.
   ...
   ./eosd --skip-transaction-signatures
   ...

plugins/chain_plugin/chain_plugin.cpp

@@ -114,13 +114,13 @@ void chain_plugin::plugin_initialize(const variables_map& options) {
       ilog("Setting skip_transaction_signatures");
       elog("Setting skip_transaction_signatures\n"
            "\n"
-           "***************************************\n"
-           "*                                     *\n"
-           "*   -- CHAIN IGNORING SIGNATURES --   *\n"
-           "*   -         TEST MODE           -   *\n"
-           "*   -------------------------------   *\n"
-           "*                                     *\n"
-           "***************************************\n");
+           "**************************************\n"
+           "*                                    *\n"
+           "*   -- EOSD IGNORING SIGNATURES --   *\n"
+           "*   -         TEST MODE          -   *\n"
+           "*   ------------------------------   *\n"
+           "*                                    *\n"
+           "**************************************\n");
 
       my->skip_flags |= chain_controller::skip_transaction_signatures;
    }
@@ -187,9 +187,6 @@ bool chain_plugin::accept_block(const chain::signed_block& block, bool currently
 }
 
 void chain_plugin::accept_transaction(const chain::SignedTransaction& trx) {
-   if (my->skip_flags & chain_controller::skip_transaction_signatures) {
-      wlog("skip_transaction_signatures enabled");
-   }
    chain().push_transaction(trx, my->skip_flags);
 }
 
@@ -201,7 +198,7 @@ bool chain_plugin::block_is_on_preferred_chain(const chain::block_id_type& block
    return chain().get_block_id_for_num(chain::block_header::num_from_id(block_id)) == block_id;
 }
 
-bool chain_plugin::skip_transaction_signatures() const {
+bool chain_plugin::is_skipping_transaction_signatures() const {
    return my->skip_flags & chain_controller::skip_transaction_signatures;
 }
 
@@ -329,9 +326,6 @@ read_write::push_block_results read_write::push_block(const read_write::push_blo
 }
 
 read_write::push_transaction_results read_write::push_transaction(const read_write::push_transaction_params& params) {
-   if (skip_flags & chain_controller::skip_transaction_signatures) {
-      wlog("skip_transaction_signatures enabled");
-   }
    auto ptrx = db.push_transaction(params, skip_flags);
    auto pretty_trx = db.transaction_to_variant( ptrx );
    return read_write::push_transaction_results{ params.id(), pretty_trx };

plugins/chain_plugin/include/eos/chain_plugin/chain_plugin.hpp

@@ -181,7 +181,7 @@ public:
    bool block_is_on_preferred_chain(const chain::block_id_type& block_id);
 
    // return true if --skip-transaction-signatures passed to eosd
-   bool skip_transaction_signatures() const;
+   bool is_skipping_transaction_signatures() const;
 
    // Only call this after plugin_startup()!
    chain_controller& chain();

plugins/producer_plugin/producer_plugin.cpp

@@ -239,8 +239,7 @@ block_production_condition::block_production_condition_enum producer_plugin_impl
    fc::time_point now_fine = fc::time_point::now();
    fc::time_point_sec now = now_fine + fc::microseconds(500000);
 
-   if (app().get_plugin<chain_plugin>().skip_transaction_signatures()) {
-      //wlog("skip_transaction_signatures enabled");
+   if (app().get_plugin<chain_plugin>().is_skipping_transaction_signatures()) {
       _production_skip_flags |= chain_controller::skip_transaction_signatures;
    }
    // If the next block production opportunity is in the present or future, we're synced.