Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
youngwolf
ascs
提交
26b1472c
A
ascs
项目概览
youngwolf
/
ascs
通知
5
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
A
ascs
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
26b1472c
编写于
3月 18, 2020
作者:
Y
youngwolf
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Some more comments about the thread safety for socket::get_statistic().
上级
06112dd8
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
6 addition
and
4 deletion
+6
-4
examples/echo_server/echo_server.cpp
examples/echo_server/echo_server.cpp
+1
-1
include/ascs/socket.h
include/ascs/socket.h
+5
-3
未找到文件。
examples/echo_server/echo_server.cpp
浏览文件 @
26b1472c
...
...
@@ -89,7 +89,7 @@ public:
//because we use objects pool(REUSE_OBJECT been defined), so, strictly speaking, this virtual
//function must be rewrote, but we don't have member variables to initialize but invoke father's
//reset() directly, so, it can be omitted, but we keep it for possibly future using
virtual
void
reset
()
{
super
::
reset
();}
virtual
void
reset
()
{
super
::
reset
();}
protected:
virtual
void
on_recv_error
(
const
asio
::
error_code
&
ec
)
...
...
include/ascs/socket.h
浏览文件 @
26b1472c
...
...
@@ -202,9 +202,11 @@ public:
size_t
msg_handling_interval
()
const
{
return
msg_handling_interval_
;}
//in ascs, it's thread safe to access stat without mutex, because for a specific member of stat, ascs will never access it concurrently.
//but user can access stat out of ascs via get_statistic function, although user can only read it, there's still a potential risk,
//so whether it's thread safe or not depends on std::chrono::system_clock::duration.
//i can make it thread safe in ascs, but is it worth to do so? this is a problem.
//but user can access stat out of ascs via get_statistic function, although user can only read it, there's still a potential risk (especially
// on 32 bit system, most likely, it will not be thread safe), so whether it's thread safe or not depends on std::chrono::system_clock::duration.
//i can make it thread safe in ascs, but is it worth to do so? because it affect performance a lot, this is a problem.
//by the way, only with macro ASCS_FULL_STATISTIC, above potential risk can happen, even it happens, it just corrupt data, not memory, so just
// logic error, no memory error (such as segment fault, bad memory, etc.) will occur.
const
struct
statistic
&
get_statistic
()
const
{
return
stat
;}
//get or change the packer at runtime
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录