1. 25 6月, 2018 4 次提交
    • S
    • S
      Adopt recommendations · a8f5bf89
      Sandeep Somavarapu 提交于
      - Get recommendation source along with recommendations
      - Add recommendation source to extensions
      - Adopt recommendations for muliple management
      a8f5bf89
    • R
      Add "Recommend" action to extension viewlet (#50419) · 5eea6bcc
      Ronald Rey 提交于
      * Add "Recommend" action to extension viewlet
      
      Related to #13456
      
      * Address PR requested changes
      
      * Change functionality and UX
      
      - Button goes from "Add to workspace recommendations" (clickable) to
        "Adding to workspace recommendations..." (unclickable) to
        "Added to workspace recommendations" (unclickable).
      - It is only visible if the current extension is installed and there's
        at least one folder in the root that doesn't have it recommended yet.
        In other words, if it's already recommended in every folder of the root,
        it is not visible.
      - In a single-root setup, it's immediately added to the recommendations.
      - In a multi-root setup, a quick-pick is displayed with only the folders
        where it is not yet recommended available as options.
      - In a multi-root setup, the button will go back to
        "Add to workspace recommendations" (clickable) instead of the
        unclickable state if there are still folders remaining where the
        current extension is not yet recommended.
      - An error or success notification is displayed after the work is done.
      - Configuration files are created if don't exist, modified otherwise.
      
      * Don't show the button if ext is recommended in ANY folder
      
      In the previous commit, the button would be displayed as long as there
      was at least one folder in the workspace where the extension wasn't
      recommended.
      
      Now, the button will be displayed only if the current extension is not
      recommended in any of the folders, as suggested in
      https://github.com/Microsoft/vscode/pull/50419#issuecomment-398216711
      
      * Improvements based on PR suggestions
      
      - Lowercasing the extension ID before comparing
      - Directly styling & labeling the button on the `run` command after work is done instead of calling `update`.
      - Fix & delete unnecessary styles
      
      * Expose feature as command instead of button
      
      After a discussion with @ramya-rao-a and other members of the team,
      it was decided that it wasn't reasonable to have a dedicated button for
      a feature that's rarely used in such a visible place.
      
      So instead, the action will be exposed as a command that will only be
      available when there's an extension open in the editor area. In contrast
      with the previous implementation, this has the added benefit of
      allowing the user to use this action to recommend uninstalled
      extensions as well.
      
      * Simplify conditions for AddToRecommendations action
      
      * Move comments so that they dont get erased when recommendations are added programatically
      
      * Remove from unwanted before adding to recommendations
      
      * Array improvements
      
      * Friendly error msg
      5eea6bcc
    • E
      Improve Extension editor UI (#52126) · 4ae06bd9
      EbXpJ6bp 提交于
      Improve Dependencies and Contributions UI in the Extension editor
      4ae06bd9
  2. 23 6月, 2018 3 次提交
  3. 22 6月, 2018 8 次提交
  4. 21 6月, 2018 1 次提交
  5. 20 6月, 2018 6 次提交
    • S
      #52342 Fix classes contributed to themes · 738fa55a
      Sandeep Somavarapu 提交于
      738fa55a
    • S
      Revert "Fix #52342" · 3db3905e
      Sandeep Somavarapu 提交于
      This reverts commit 81f54be0.
      3db3905e
    • S
      Fix #52342 · 81f54be0
      Sandeep Somavarapu 提交于
      81f54be0
    • J
      Remove button that shouldnt show up (#52360) · 69d79b07
      Jackson Kearl 提交于
      69d79b07
    • J
      Add ability to ignore recommendations both globally and at a per-workspace level (#51941) · 442e5e20
      Jackson Kearl 提交于
      * WIP
      
      * Initail filtering and pulling filter list logic.
      
      * Imporive typing and naming
      
      * Remove the significant duplication
      
      * Bug fixes.
      
      * Fix bug where arrow functions dont maintain `this` in point free style
      
      * WIP on extension ignoring UI.
      
      * UI for global ignores.
      
      * Add "unwantedRecommendations" to extensions.json template and intelisense
      
      * Notify of workspace non-recommended extensions
      
      * Wording of extensions.json template
      
      * More UI for ignore button.
      
      * Use seprate notification channel of recommendation changes.
      
      * Reload search when recommended extensions changes
      
      * Tests for ExtensionTipsService
      
      * Test extensions workbench service
      
      * Naming and add default vaule to workspace settings
      
      * Initial revisions
      
      * Global ignore need not call workspace refresh
      
      * Fix build issues
      
      * Skip refreshing workspace twice
      
      * WIP
      
      * WIP
      
      * Reduce file accesses.
      Remove bug causing all open editors to show exrtension as ignored
      
      * Fix some of the build issues.
      
      * Hackish thing that fixes the test.
      
      * Rename id to extensionId in RecommendationChangeNotification
      
      * updateRecommendedness ??
      
      * Not needed
      
      * Remove point free style thing
      
      * Simplify
      
      * naming
      
      * remove extrenous getWrokspaceRecommendations call
      
      * Casing
      
      * Gracefull handle missing 'extensions' field in multiroot project config
      
      * Refresh recommendation views on recommendation change
      
      * more case sensitivity stuff
      
      * naming/refactroing
      
      * Simplify return types
      
      * Wording
      
      * Add telemetry
      
      * guard telemetry service
      442e5e20
    • S
      removing invalid classes from extension actions · dcffd798
      SteVen Batten 提交于
      dcffd798
  6. 16 6月, 2018 2 次提交
  7. 15 6月, 2018 2 次提交
  8. 12 6月, 2018 2 次提交
    • R
      Allow customization of the viewlets in the default Extensions view (#47766) · e8fc8943
      ryenus 提交于
      * add Enabled/Disabled extensions list view
      
      * extract viewOrder calculation logic
      
      and return Number.MAX_VALUE instead of Number.POSITIVE_INFINITY for
      views end up with undefined order, when comparing two views like this,
      we get Number.MAX_VALUE - Number.MAX_VALUE = 0, rather than NaN
      caused by infinity arithmetic.
      
      * allow Installed Extensions view to be toggled off
      
      * refine query for enabled/disabled extensions
      
      * simplify query for enabled/disabled extensions
      
      * disabled extensions also include built-in ones
      e8fc8943
    • J
      Feature request: remove auto-closing of extension details (#51399) · f15deb51
      Jackson Kearl 提交于
      * Don't close extensions on navigating to different activity view.
      Add a config option to restore previous behaviour.
      
      * Naming
      
      * Naming #2
      
      * Update wording.
      f15deb51
  9. 09 6月, 2018 1 次提交
  10. 08 6月, 2018 4 次提交
  11. 06 6月, 2018 2 次提交
  12. 05 6月, 2018 2 次提交
    • S
      #48535 Adopt to contributable views model · 3cc954a4
      Sandeep Somavarapu 提交于
      3cc954a4
    • B
      bring titlebarplus up to date · 06df9575
      Benjamin Pasero 提交于
      * Merge NPM Scripts: Added configuration option to change default click action #49282
      
      * fix #50560
      
      * Fix getmac test (#48804)
      
      * Cleaning up some typos in vscode.d.ts and vscode.proposed.d.ts (#50533)
      
      * yarn.lock changes
      
      * grid - log serialized state if restoring failed
      
      * Fixes #50382: Align .mtku with .detected-link
      
      * debug issues back to isidorn
      
      * Hide interactive playground commands from command palette (fixes #49706)
      
      * grid - drop outline as focus indication and rely on dimmed state
      
      * grid - allow to close empty group when closing all editors of a group
      
      * grid - get preferredSize from grid
      
      * Fixes #43003: Cannot specify a global problemMatcher in tasks.json
      
      * cleanup integrated terminal support for debugging
      
      * grid - action wording tweaks
      
      * #45663 Use core translations asset
      
      * grid - allow to close dirty diff editor if master is still opened in same group
      
      * Support to run npm install from a package node
      
      * grid - log previous UI state upon error
      
      * grid - stronger border top color
      
      otherwise when a tab is showing in a vertical split, the border collides with the sash border
      
      * remove todo
      
      * do not append logLevel
      
      #47774
      
      * Implement Go To Next/Previous Breakpoint editor actions
      
      * Include enabledOnly in debug model interface
      
      * remove from schema
      
      #47774
      
      * #45663 fix compilations
      
      * change openBreakpointSource to use IBreakpoint
      
      * return passed context if resourceOrContext is not useful
      
      * fix off by one issue
      
      * Simplify implementation
      
      * return context if it has a groupId
      
      * polish
      
      * Fixes Microsoft/monaco-editor#891: Focus editor when returning from context menu
      
      * go to next / previosu breakpoint minor polish
      
      * Add Endgame for 1.24
      
      * fix index computing for editor close case
      
      * Fix #49145
      
      - Enable/Disable viewlets by views when context
      - Move viewlet enablement/disablement to views service
      - Fix - adopt if a viewlet extension is disabled/removed
      
      * Avoid command palette entry (#49340)
      
      * [handlebars] code-folding algorithm is less useful than Indentation-based one. Fixes #48457
      
      * use upper lang id
      
      * Fixes #49378
      
      * #49145 Store placeholder states for all viewlets
      
      * Add `logicalLine` argument to `mutlicursor.insertBelow` and `mutlicursor.insertAbove`
      
      * Removed duplicate loop
      
      * eliminate code duplication; use resolveWorkspaceFolder()
      
      * #45663 Get all asset types
      
      * [css] update service
      
      * [html] update services
      
      * grid - fix compile
      
      * add User-Id to marketplace build requests
      
      * Improve rendererType description
      
      Fixes #50617
      
      * fix #50672
      
      * Fixes #49173
      
      * fix #50321
      
      * fix #50670
      
      * Install option not needed when we have Install and Restart Fixes #50669
      
      * Fixes #50616, Showing/hiding details in Issue Reporter resets scroll position
      
      * Fix #50642, fix #50673
      
      * Issue reporter and process explorer windows should close when the parent window closes, fixes #50716
      
      * Issue Reporter should clear the error state when selecting an extension, fixes #50702
      
      * Extracting methods
      
      * Make sure we update the webview's state on setState
      
      * Avoid prompting for same file type in the same session #50537
      
      * Use language name instead of locale in the prompt #50738
      
      * Use correct failed error code for webview resource load error
      
      * Mark unused parameter
      
      * Restore restart
      
      * Try serializing webviews even if they have not called setState
      
      Fixes #50752
      
      * Change parameter name to match interface name
      
      Fixes #50745
      
      * Fix non-serializable webviews being revived if they called setState
      
      * Include recommended extensions in telemetry events to determine success
      
      * Fix #49777 - Emmet balance In after balance out should go back to initial selection and not first child (#49996)
      
      * Update Emmet - balance.ts
      
      * Cover all cases
      
      * Update prompt msg Fixes #50738
      
      * Fix #50632
      
      * search-rg has no icon
      
      * EH search - replace search.enableSearchProviders with a search-rg specific setting
      
      * fix #50742
      
      * fix #50691
      
      * part of #50760
      
      * smoke: uncomment debug suite
      
      * smoketest: use yarn
      
      * grid - allow to close empty groups via middle click (#50733)
      
      * careful with path comparisons on windows
      
      related to #50760
      
      * smoke: run yarn verbose
      
      * fix #50710
      
      * Improve description (#43208)
      
      * fix #50722
      
      * Fix #50663
      
      * Fix #47586
      
      * fixes #50609
      
      * fixes #50026
      
      * 💄
      
      * fix  #50773
      
      * improve perf of findId and getElementById, #50575
      
      * don't show outline when there are more then 7500 symbols, #50575
      
      * fix typos
      
      * polish for #50667
      
      * fix #50700
      
      * grid keep sizing after branch node demotion
      
      fixes #50564
      
      * grid - for now remove editorGroup.activeEmptyBackground
      
      * fix #50726
      
      * grid: resize views when branch is demoted
      
      fixes #50675
      
      * fix #50727
      
      * fix #50734
      
      * remove preview rant from search.location
      
      * splitview: dont propagate white-sapce property
      
      fixes #50720
      
      * fix #50774
      
      * Fixes #50296
      
      * fix  #50207
      
      * Fixes #24670: Add API to determine if the task service supports parallel task execution.
      
      * fix #50741
      
      * Fixes  #49400: Cannot read property 'then' of undefined
      
      * Fix #50717
      
      * Fix #48901
      
      * polish debug.toolBarLocation
      
      fixes #50786
      
      * Fix #50717
      
      * missing compilation
      
      * Fix #48225
      
      * fix #50711
      
      * Fix errors installing extension from Welcome page (fixes #50753)
      
      * fixes #50794
      
      * fixes #50787
      
      * continuous build: use vsts npm feed
      
      * Fix for #50792: empty pre post scripts not rendered properly
      
      * Fix #50728
      
      * continuous build: use vsts feed
      
      * Fix for #50792 npm exclude doesn´t work for folder names
      
      * Move previewOptions, #50788
      
      * build: remove npm auth
      
      * better fix for #50710
      
      * Revert "Merge pull request #49790 from usernamehw/raw_settings"
      
      This reverts commit f92a162b, reversing
      changes made to fc710af7.
      
      * Remove unused variable
      
      * Fix regression in C# TextMate grammar related to lambda parameters
      
      This tweak fixes a regression recently introduced in the C# TextMate grammar around
      implicitly-typed lambda parameters.
      
      * https://github.com/dotnet/csharp-tmLanguage/issues/119
      * https://github.com/dotnet/csharp-tmLanguage/issues/120
      
      * Fix parameter not being escaped
      
      Fixes #49057
      
      * wip: grid.getNeighborViews
      
      * Make sure we use normalized path for compare
      
      Fixes #50760
      
      (the path should already have been normalized at this point so I don't think there is any user impact)
      
      * Clean up importModuleSpecifier wording
      
      Fixes #50817
      
      * Remove duplicate strings and small cleanup
      
      * Spelling fix Ouoting -> Quoting
      
      * Restore default settings editor keybinding
      
      * Dont trigger emmet for # in selectors Fixes #49269
      
      * Hide settings editor feedback button in stable
      
      * Use better colors for markdown code blocks
      
      * Moving webview api back to proposed for more polishing
      
      #49022
      
      * Shorten showUnused setting name
      
      Fixes #50648
      
      * fix #50678
      
      * Don't include imports in js/ts document symbol results
      
      Fixes #50829
      
      * smoketest: remove verbose from yarn
      
      * smoketest: clear state from failing search tests
      
      * minor rename
      
      * Fix markdown preview not setting context properly on first creation
      
      Fixes #50558
      
      * smoketest: update to package-lock.json
      
      fixes #50857
      
      * smoketest: bring back search tests
      
      * #48901 Expand by default only in custom viewlets
      
      * fixes #50812
      
      * open editors: clear focus when group without editors is active
      
      fixes #50563
      
      * Fix MaxNumber incrementFileName bug
      
      * Fixes #48758: Do not import standalone editor modules
      
      * fixes #50864
      
      * Use `MAX_SAFE_SMALL_INTEGER`
      
      * Fixes #50858: Task api is still marked as proposed
      
      * fixes #50737
      
      * fix #50867
      
      * Fix: showQuickPick keeps showing infinite progress (fixes #50863)
      
      * Clarify for translation (fixes #50634)
      
      * fixes #50870
      
      * fix #50479
      
      * grid - todo@grid => todo@ben
      
      * grid - adopt new getNeighborViews() method
      
      * grid - add workbench.action.closeEditorsAndGroup
      
      * open editors: close group action
      
      fixes #50625
      
      * open editors: use actionRunner for contexts
      
      fixes #50621
      
      * [css][html] update service
      
      * grid: getNeighborViews
      
      * grid - adopt wrapping
      
      * Some menu action clients (ActionBar) handle alternative actions on their own so the alternative actions should be ignored
      
      fixes #50581
      
      * fillInActionBarActions and fillInContextMenuActions for clarity
      
      * Remove inconsistent use of active in terminal API
      
      Related #48434
      
      * Try using fixAllDescription for js/ts quick fixes
      
      Fixes #42549
      
      * Fixes #50828, code-insiders --status triggered exception in main process
      
      * Pick up ts 2.9.1 final
      
      * Fix for #50868 and #50884
      
      * Still gray out vars even if user has disabled suggestions
      
      Fixes #50890
      
      * grid: fix neighbor npe issue
      
      * grid: more getNeighborViews tests
      
      * grid: use boundaries for neighbor finding
      
      * grid: getNeighborViews perf
      
      * grid: add todo
      
      * 2018-05-31. Merged in translations from Transifex.
      
      * Update GDPR annotation
      
      * update message
      
      * Add specific `refactor.move` scope for js/ts move to new file action
      
      * Use localized language name when available
      
      * Add proper contribution schema for ts server pluguins
      
      #50682
      
      * Fix extra word
      
      * Fix #50909 - add link to new settings editor from old one
      
      * Left-align settings editor preview prompt
      
      * grid - fix issues with touchbar updating
      
      * grid - use viewColumnToEditorGroup in more places
      
      * grid - close all groups should preserve first group
      
      * Reapply fix for #50790
      
      * grid - assign some default keybindings for focus group
      
      * Fixes #50763: All running Visual Studio code instances shutdown all at once
      
      * grid - 💄
      
      * fixes #50926
      
      * show alternative actions when alt is pressed, not only on mouse over
      
      * open editors: click on groups should activate them
      
      * update description (for #50677)
      
      * Fix #50835
      
      * grid - tweak some groups access order
      
      * one more time, fix #50321
      
      * beware of keybinding command null arguments
      
      fixes #50821
      
      * grid - prevent multiple confirmation dialogs for the same editor to show up (for  #50539)
      
      * smoketest: go-to-definition is flaky
      
      fixes #50944
      fixes #49107
      
      * Fixes #50943: TSC version 2.9.x in watch mode prints different end compile message
      
      * grid - fix bad === for editors
      
      * 💄 grid, cleanup getViews()
      
      * Update distro commit and third party notices
      
      * Use localizedLanguageName instead of languageNameLocalized which doesnt exist
      
      * Remove now unneeded any
      
      * Make sure unused diags are still updated when suggestions are disabled
      
      Fixes #50890
      
      * Fix unused var
      
      * Update version
      
      * Update issue templates, #49380
      
      * Fix #50893 - escape regex chars when copy search string from editor
      
      * Fix #50985 - don't take editor text when toggling search details
      06df9575
  13. 02 6月, 2018 1 次提交
  14. 01 6月, 2018 1 次提交
  15. 30 5月, 2018 1 次提交