1. 15 10月, 2019 8 次提交
    • C
      minimap - allow variable scaling (#82265) · 5767f6f2
      Connor Peet 提交于
      * minimap - allow variable scaling
      
      This PR allows the minimap to be scaled to several constant values. Most of the
      work in this PR is adjusting the the font renderer to render character at
      variable sizes. It turns out most generic image scaling algorithms are not
      built to scale down to one or two pixels (the default minimap font size has
      1px by 2px characters), so some work was needed to make this possible and look
      good.
      
      Generating fonts at runtime does incur a small performance penalty, taking
      about 0.6m at 1x scale and 0.9ms at 4x scale on my machine to create the font
      the first time we render a minimap. If we want to avoid this, we could consider
      shipping pre-rendered font for the first few scale settings.
      
      At this moment this only supports scaling to a constant integer--effectively,
      scaling the character width, since we start at 1x2px. More granular scaling
      would be interesting, but will come at a runtime cost as we'll need to do
      linear interpolation for each character we draw at a non-integral coordinate.
      
      Draw speed is comparable to the previous version, the profiler reported in
      the range of 8-11ms to render my test file in both the previous and new code.
      
      I've tested this on my high DPI Macbook display and it appears to work well
      there too.
      
      Talking to Alex, something we may need to look into is matching the user font
      and render settings. Previously, and continuing in this PR, we use the default
      monospace font on the system with a restricted set of character codes.
      Previously the sidebar's font was too small to be visible, but now its content
      can be seen under large settings. We may need to look and reworking how this
      data is rendered. Perhaps we generate the characters we need on the fly into
      their own buffers? Open to ideas.
      
      Fixes https://github.com/microsoft/vscode/issues/21773
      
      * fixup! not caching created factory
      
      * fix common/browser component layering
      
      * fixup! use a constant upscale for hDPI
      
      * small tweaks
      
      * fixup! pr comments
      
      * fixup! reduce max minimap scale
      5767f6f2
    • M
      Merge pull request #82395 from microsoft/misolori/monokai-theme · aad1e683
      Miguel Solorio 提交于
      Improve readability of comments in diff view for Monokai theme
      aad1e683
    • M
      Merge branch 'master' into misolori/monokai-theme · 12625aaf
      Miguel Solorio 提交于
      12625aaf
    • M
      Fix #64684 · c534a1ce
      Miguel Solorio 提交于
      c534a1ce
    • B
      Revert "🆙 graceful-fs@4.2.2 (#82058)" · 55aa1de9
      Benjamin Pasero 提交于
      This reverts commit 3c70da4c.
      55aa1de9
    • M
      Map 'stop' Octicon to 'error' Codicon · cbf76420
      Miguel Solorio 提交于
      cbf76420
    • B
      strict null · a65701ec
      Benjamin Pasero 提交于
      a65701ec
    • M
      Update Codicon icon mapping for Octicons · 774a6b0b
      Miguel Solorio 提交于
      774a6b0b
  2. 14 10月, 2019 32 次提交