提交 f5ad7129 编写于 作者: R rebornix

fix transformed output rendering for nteract.

上级 c9789eec
......@@ -14,24 +14,24 @@ export function activate(context: vscode.ExtensionContext) {
context.subscriptions.push(vscode.window.registerNotebookProvider('jupyter', new NotebookProvider(context.extensionPath, true)));
context.subscriptions.push(vscode.window.registerNotebookProvider('jupytertest', new NotebookProvider(context.extensionPath, false)));
context.subscriptions.push(vscode.window.registerNotebookOutputRenderer(
'kerneltest',
{
type: 'display_data',
subTypes: [
'text/latex',
'text/markdown',
'application/json',
'application/vnd.plotly.v1+json',
'application/vnd.vega.v5+json'
]
},
{
render: () => {
return '<h1>kernel test renderer</h1>';
}
}
));
// context.subscriptions.push(vscode.window.registerNotebookOutputRenderer(
// 'kerneltest',
// {
// type: 'display_data',
// subTypes: [
// 'text/latex',
// 'text/markdown',
// 'application/json',
// 'application/vnd.plotly.v1+json',
// 'application/vnd.vega.v5+json'
// ]
// },
// {
// render: () => {
// return '<h1>kernel test renderer</h1>';
// }
// }
// ));
vscode.commands.registerCommand('notebook.saveToMarkdown', () => {
if (vscode.window.activeNotebookDocument) {
......
......@@ -258,7 +258,8 @@ export class ExtHostNotebookDocument implements vscode.NotebookDocument, vscode.
output.pickedRenderer = handler[0].handle;
// output.transformedOutput = transformedOutput;
output.transformedOutput = { richestMimeType: transformedOutput };
output.transformedOutput = {};
output.transformedOutput[richestMimeType] = transformedOutput;
}
}
......@@ -310,7 +311,8 @@ export class ExtHostNotebookDocument implements vscode.NotebookDocument, vscode.
transformedOutput = pickedHandler.render(this, cell, output);
(<IGenericOutput>output).pickedRenderer = pickedHandler.handle;
(<IGenericOutput>output).transformedOutput = { richestMimeType: transformedOutput };
(<IGenericOutput>output).transformedOutput = {};
(<IGenericOutput>output).transformedOutput![richestMimeType] = transformedOutput;
}
}
......
......@@ -232,7 +232,7 @@ export class CodeCell extends Disposable {
}
}
let result = this.notebookEditor.getOutputRenderer().render(transformedOutput!, outputItemDiv, currOutput.pickedMimeType);
let result = this.notebookEditor.getOutputRenderer().render(transformedOutput!, outputItemDiv, transformedMimeType!);
if (!result) {
this.viewCell.updateOutputHeight(index, 0);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册