Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
f515c229
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
f515c229
编写于
7月 29, 2019
作者:
J
Johannes Rieken
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
make edit-builder throw when used after finalized, #78066
上级
7291ef2b
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
37 addition
and
4 deletion
+37
-4
extensions/vscode-api-tests/src/singlefolder-tests/editor.test.ts
...ns/vscode-api-tests/src/singlefolder-tests/editor.test.ts
+23
-0
src/vs/workbench/api/common/extHostTextEditor.ts
src/vs/workbench/api/common/extHostTextEditor.ts
+14
-4
未找到文件。
extensions/vscode-api-tests/src/singlefolder-tests/editor.test.ts
浏览文件 @
f515c229
...
...
@@ -195,4 +195,27 @@ suite('editor tests', () => {
);
});
});
test
(
'
throw when using invalid edit
'
,
async
function
()
{
await
withRandomFileEditor
(
'
foo
'
,
editor
=>
{
return
new
Promise
((
resolve
,
reject
)
=>
{
editor
.
edit
(
edit
=>
{
edit
.
insert
(
new
Position
(
0
,
0
),
'
bar
'
);
setTimeout
(()
=>
{
try
{
edit
.
insert
(
new
Position
(
0
,
0
),
'
bar
'
);
reject
(
new
Error
(
'
expected error
'
));
}
catch
(
err
)
{
assert
.
ok
(
true
);
resolve
();
}
},
0
);
});
});
});
});
});
src/vs/workbench/api/common/extHostTextEditor.ts
浏览文件 @
f515c229
...
...
@@ -51,21 +51,21 @@ export class TextEditorEdit {
private
readonly
_document
:
vscode
.
TextDocument
;
private
readonly
_documentVersionId
:
number
;
private
_collectedEdits
:
ITextEditOperation
[];
private
_setEndOfLine
:
EndOfLine
|
undefined
;
private
readonly
_undoStopBefore
:
boolean
;
private
readonly
_undoStopAfter
:
boolean
;
private
_collectedEdits
:
ITextEditOperation
[]
=
[];
private
_setEndOfLine
:
EndOfLine
|
undefined
=
undefined
;
private
_finalized
:
boolean
=
false
;
constructor
(
document
:
vscode
.
TextDocument
,
options
:
{
undoStopBefore
:
boolean
;
undoStopAfter
:
boolean
;
})
{
this
.
_document
=
document
;
this
.
_documentVersionId
=
document
.
version
;
this
.
_collectedEdits
=
[];
this
.
_setEndOfLine
=
undefined
;
this
.
_undoStopBefore
=
options
.
undoStopBefore
;
this
.
_undoStopAfter
=
options
.
undoStopAfter
;
}
finalize
():
IEditData
{
this
.
_finalized
=
true
;
return
{
documentVersionId
:
this
.
_documentVersionId
,
edits
:
this
.
_collectedEdits
,
...
...
@@ -75,7 +75,14 @@ export class TextEditorEdit {
};
}
private
_throwIfFinalized
()
{
if
(
this
.
_finalized
)
{
throw
new
Error
(
'
Edit is only valid while callback runs
'
);
}
}
replace
(
location
:
Position
|
Range
|
Selection
,
value
:
string
):
void
{
this
.
_throwIfFinalized
();
let
range
:
Range
|
null
=
null
;
if
(
location
instanceof
Position
)
{
...
...
@@ -90,10 +97,12 @@ export class TextEditorEdit {
}
insert
(
location
:
Position
,
value
:
string
):
void
{
this
.
_throwIfFinalized
();
this
.
_pushEdit
(
new
Range
(
location
,
location
),
value
,
true
);
}
delete
(
location
:
Range
|
Selection
):
void
{
this
.
_throwIfFinalized
();
let
range
:
Range
|
null
=
null
;
if
(
location
instanceof
Range
)
{
...
...
@@ -115,6 +124,7 @@ export class TextEditorEdit {
}
setEndOfLine
(
endOfLine
:
EndOfLine
):
void
{
this
.
_throwIfFinalized
();
if
(
endOfLine
!==
EndOfLine
.
LF
&&
endOfLine
!==
EndOfLine
.
CRLF
)
{
throw
illegalArgument
(
'
endOfLine
'
);
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录