Fixing integrated terminal font-size overflow

src/vs/workbench/parts/terminal/electron-browser/terminalConfigHelper.ts

@@ -29,6 +29,7 @@ interface IFullTerminalConfiguration {
 const DEFAULT_LINE_HEIGHT = 1.0;
 
 const MINIMUM_FONT_SIZE = 6;
+const MAXIMUM_FONT_SIZE = 25;
 
 /**
  * Encapsulates terminal configuration logic, the primary purpose of this file is so that platform
@@ -101,7 +102,7 @@ export class TerminalConfigHelper implements ITerminalConfigHelper {
 			}
 		}
 
-		let fontSize = this._toInteger(terminalConfig.fontSize, MINIMUM_FONT_SIZE, EDITOR_FONT_DEFAULTS.fontSize);
+		let fontSize = this._toInteger(terminalConfig.fontSize, MINIMUM_FONT_SIZE, MAXIMUM_FONT_SIZE, EDITOR_FONT_DEFAULTS.fontSize);
 		const lineHeight = terminalConfig.lineHeight ? Math.max(terminalConfig.lineHeight, 1) : DEFAULT_LINE_HEIGHT;
 
 		if (excludeDimensions) {
@@ -179,7 +180,7 @@ export class TerminalConfigHelper implements ITerminalConfigHelper {
 		}
 	}
 
-	private _toInteger(source: any, minimum: number, fallback: number): number {
+	private _toInteger(source: any, minimum: number, maximum: number, fallback: number): number {
 		let r = parseInt(source, 10);
 		if (isNaN(r)) {
 			return fallback;
@@ -187,6 +188,9 @@ export class TerminalConfigHelper implements ITerminalConfigHelper {
 		if (typeof minimum === 'number') {
 			r = Math.max(minimum, r);
 		}
+		if (typeof maximum === 'number') {
+			r = Math.min(maximum, r);
+		}
 		return r;
 	}
 }
\ No newline at end of file