debug polish: remove debugService.setBreakpointsForModel

src/vs/workbench/parts/debug/browser/debugEditorModelManager.ts

@@ -4,6 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import nls = require('vs/nls');
+import { TPromise } from 'vs/base/common/winjs.base';
 import objects = require('vs/base/common/objects');
 import lifecycle = require('vs/base/common/lifecycle');
 import editorcommon = require('vs/editor/common/editorCommon');
@@ -223,7 +224,12 @@ export class DebugEditorModelManager implements IWorkbenchContribution {
 		}
 		modelData.dirty = !!this.debugService.getActiveSession();
 
-		this.debugService.setBreakpointsForModel(modelUrl, data);
+		const toRemove = this.debugService.getModel().getBreakpoints()
+			.filter(bp => bp.source.uri.toString() === modelUrl.toString());
+
+		TPromise.join(toRemove.map(bp => this.debugService.removeBreakpoints(bp.getId()))).then(() => {
+			this.debugService.addBreakpoints(data);
+		});
 	}
 
 	private onBreakpointsChange(): void {

src/vs/workbench/parts/debug/common/debug.ts

@@ -304,7 +304,6 @@ export interface IDebugService {
 	/**
 	 * General breakpoints manipulation.
 	 */
-	setBreakpointsForModel(modelUri: uri, rawData: IRawBreakpoint[]): void;
 	addBreakpoints(rawBreakpoints: IRawBreakpoint[]): TPromise<void[]>;
 	enableOrDisableAllBreakpoints(enabled: boolean): TPromise<void>;
 	toggleEnablement(element: IEnablement): TPromise<void>;

src/vs/workbench/parts/debug/electron-browser/debugService.ts

@@ -426,12 +426,6 @@ export class DebugService implements debug.IDebugService {
 		}
 	}
 
-	public setBreakpointsForModel(modelUri: uri, rawData: debug.IRawBreakpoint[]): void {
-		this.model.removeBreakpoints(
-			this.model.getBreakpoints().filter(bp => bp.source.uri.toString() === modelUri.toString()));
-		this.model.addBreakpoints(rawData);
-	}
-
 	public enableOrDisableAllBreakpoints(enabled: boolean): TPromise<void>{
 		this.model.enableOrDisableAllBreakpoints(enabled);
 		return this.sendAllBreakpoints();

src/vs/workbench/parts/debug/test/common/mockDebugService.ts

@@ -37,8 +37,6 @@ export class MockDebugService implements debug.IDebugService {
 		return TPromise.as(null);
 	}
 
-	public setBreakpointsForModel(modelUri: uri, rawData: debug.IRawBreakpoint[]): void {}
-
 	public addBreakpoints(rawBreakpoints: debug.IRawBreakpoint[]): TPromise<void[]> {
 		return TPromise.as(null);
 	}