提交 ef7763a2 编写于 作者: J Joao Moreno

improve windows update ux

上级 15ca98b1
...@@ -355,7 +355,7 @@ export class UpdateContribution implements IGlobalActivity { ...@@ -355,7 +355,7 @@ export class UpdateContribution implements IGlobalActivity {
const handle = this.notificationService.notify({ const handle = this.notificationService.notify({
severity: severity.Info, severity: severity.Info,
message: nls.localize('updateAvailable', "There's an available update: {0} {1}", product.nameLong, update.productVersion), message: nls.localize('updateAvailable', "There's an update available: {0} {1}", product.nameLong, update.productVersion),
actions: { primary: [installUpdateAction, NotNowAction, releaseNotesAction] } actions: { primary: [installUpdateAction, NotNowAction, releaseNotesAction] }
}); });
once(handle.onDidDispose)(() => dispose(installUpdateAction, releaseNotesAction)); once(handle.onDidDispose)(() => dispose(installUpdateAction, releaseNotesAction));
...@@ -379,7 +379,7 @@ export class UpdateContribution implements IGlobalActivity { ...@@ -379,7 +379,7 @@ export class UpdateContribution implements IGlobalActivity {
// windows and mac // windows and mac
private onUpdateReady(update: IUpdate): void { private onUpdateReady(update: IUpdate): void {
if (!this.shouldShowNotification()) { if (!isWindows && !this.shouldShowNotification()) {
return; return;
} }
...@@ -396,10 +396,6 @@ export class UpdateContribution implements IGlobalActivity { ...@@ -396,10 +396,6 @@ export class UpdateContribution implements IGlobalActivity {
} }
private shouldShowNotification(): boolean { private shouldShowNotification(): boolean {
if (isWindows) {
return true;
}
const currentVersion = product.commit; const currentVersion = product.commit;
const currentMillis = new Date().getTime(); const currentMillis = new Date().getTime();
const lastKnownVersion = this.storageService.get('update/lastKnownVersion', StorageScope.GLOBAL); const lastKnownVersion = this.storageService.get('update/lastKnownVersion', StorageScope.GLOBAL);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册