lint polish

src/vs/workbench/parts/debug/common/debugModel.ts

@@ -355,7 +355,7 @@ export class Variable extends ExpressionContainer implements debug.IExpression {
 export class Scope extends ExpressionContainer implements debug.IScope {
 
 	constructor(
-		private threadId: number,
+		threadId: number,
 		public name: string,
 		reference: number,
 		public expensive: boolean,

src/vs/workbench/parts/debug/electron-browser/debugService.ts

@@ -93,7 +93,7 @@ export class DebugService implements debug.IDebugService {
 		@IContextKeyService contextKeyService: IContextKeyService,
 		@IEditorGroupService private editorGroupService: IEditorGroupService,
 		@IEventService eventService: IEventService,
-		@ILifecycleService private lifecycleService: ILifecycleService,
+		@ILifecycleService lifecycleService: ILifecycleService,
 		@IInstantiationService private instantiationService: IInstantiationService,
 		@IExtensionService private extensionService: IExtensionService,
 		@IMarkerService private markerService: IMarkerService,

src/vs/workbench/parts/debug/electron-browser/debugViewer.ts

@@ -29,7 +29,6 @@ import {CopyValueAction} from 'vs/workbench/parts/debug/electron-browser/electro
 import {IContextViewService, IContextMenuService} from 'vs/platform/contextview/browser/contextView';
 import {IInstantiationService} from 'vs/platform/instantiation/common/instantiation';
 import {IWorkspaceContextService} from 'vs/platform/workspace/common/workspace';
-import {IMessageService} from 'vs/platform/message/common/message';
 import {Source} from 'vs/workbench/parts/debug/common/debugSource';
 import {IKeyboardEvent} from 'vs/base/browser/keyboardEvent';
 
@@ -833,7 +832,6 @@ export class WatchExpressionsRenderer implements tree.IRenderer {
 	constructor(
 		actionProvider: renderer.IActionProvider,
 		private actionRunner: actions.IActionRunner,
-		@IMessageService private messageService: IMessageService,
 		@debug.IDebugService private debugService: debug.IDebugService,
 		@IContextViewService private contextViewService: IContextViewService
 	) {
@@ -1079,7 +1077,6 @@ export class BreakpointsRenderer implements tree.IRenderer {
 	constructor(
 		private actionProvider: BreakpointsActionProvider,
 		private actionRunner: actions.IActionRunner,
-		@IMessageService private messageService: IMessageService,
 		@IWorkspaceContextService private contextService: IWorkspaceContextService,
 		@debug.IDebugService private debugService: debug.IDebugService,
 		@IContextViewService private contextViewService: IContextViewService

src/vs/workbench/parts/debug/electron-browser/repl.ts

@@ -26,9 +26,8 @@ import {IModelService} from 'vs/editor/common/services/modelService';
 import {ServiceCollection} from 'vs/platform/instantiation/common/serviceCollection';
 import {IContextKeyService, ContextKeyExpr} from 'vs/platform/contextkey/common/contextkey';
 import {ITelemetryService} from 'vs/platform/telemetry/common/telemetry';
-import {IContextViewService, IContextMenuService} from 'vs/platform/contextview/browser/contextView';
+import {IContextMenuService} from 'vs/platform/contextview/browser/contextView';
 import {IInstantiationService, createDecorator} from 'vs/platform/instantiation/common/instantiation';
-import {IWorkspaceContextService} from 'vs/platform/workspace/common/workspace';
 import {IStorageService, StorageScope} from 'vs/platform/storage/common/storage';
 import viewer = require('vs/workbench/parts/debug/electron-browser/replViewer');
 import {ReplEditor} from 'vs/workbench/parts/debug/electron-browser/replEditor';
@@ -81,10 +80,8 @@ export class Repl extends Panel implements IPrivateReplService {
 	constructor(
 		@debug.IDebugService private debugService: debug.IDebugService,
 		@IContextMenuService private contextMenuService: IContextMenuService,
-		@IWorkspaceContextService private contextService: IWorkspaceContextService,
 		@ITelemetryService telemetryService: ITelemetryService,
 		@IInstantiationService private instantiationService: IInstantiationService,
-		@IContextViewService private contextViewService: IContextViewService,
 		@IStorageService private storageService: IStorageService,
 		@IPanelService private panelService: IPanelService,
 		@IThemeService private themeService: IThemeService,

src/vs/workbench/parts/debug/test/common/debugUtils.test.ts

@@ -8,13 +8,13 @@ import assert = require('assert');
 
 suite('Debug - Utils', () => {
 	test('formatPII', () => {
-		assert.strictEqual(debug.formatPII("Foo Bar", false, {}), "Foo Bar");
-		assert.strictEqual(debug.formatPII("Foo {key} Bar", false, {}), "Foo {key} Bar");
-		assert.strictEqual(debug.formatPII("Foo {key} Bar", false, {'key': 'yes'}), "Foo yes Bar");
-		assert.strictEqual(debug.formatPII("Foo {_0} Bar {_0}", true, {'_0': 'yes'}), "Foo yes Bar yes");
-		assert.strictEqual(debug.formatPII("Foo {0} Bar {1}{2}", false, {'0': 'yes'}), "Foo yes Bar {1}{2}");
-		assert.strictEqual(debug.formatPII("Foo {0} Bar {1}{2}", false, {'0': 'yes', '1': 'undefined'}), "Foo yes Bar undefined{2}");
-		assert.strictEqual(debug.formatPII("Foo {_key0} Bar {key1}{key2}", true, {'_key0': 'yes', 'key1': '5', 'key2': 'false'}), "Foo yes Bar {key1}{key2}");
-		assert.strictEqual(debug.formatPII("Foo {_key0} Bar {key1}{key2}", false, {'_key0': 'yes', 'key1': '5', 'key2': 'false'}), "Foo yes Bar 5false");
+		assert.strictEqual(debug.formatPII('Foo Bar', false, {}), 'Foo Bar');
+		assert.strictEqual(debug.formatPII('Foo {key} Bar', false, {}), 'Foo {key} Bar');
+		assert.strictEqual(debug.formatPII('Foo {key} Bar', false, {'key': 'yes'}), 'Foo yes Bar');
+		assert.strictEqual(debug.formatPII('Foo {_0} Bar {_0}', true, {'_0': 'yes'}), 'Foo yes Bar yes');
+		assert.strictEqual(debug.formatPII('Foo {0} Bar {1}{2}', false, {'0': 'yes'}), 'Foo yes Bar {1}{2}');
+		assert.strictEqual(debug.formatPII('Foo {0} Bar {1}{2}', false, {'0': 'yes', '1': 'undefined'}), 'Foo yes Bar undefined{2}');
+		assert.strictEqual(debug.formatPII('Foo {_key0} Bar {key1}{key2}', true, {'_key0': 'yes', 'key1': '5', 'key2': 'false'}), 'Foo yes Bar {key1}{key2}');
+		assert.strictEqual(debug.formatPII('Foo {_key0} Bar {key1}{key2}', false, {'_key0': 'yes', 'key1': '5', 'key2': 'false'}), 'Foo yes Bar 5false');
 	});
 });
\ No newline at end of file

src/vs/workbench/parts/debug/test/node/debugModel.test.ts

@@ -49,7 +49,7 @@ suite('Debug - Model', () => {
 
 	test('breakpoints two files', () => {
 		var modelUri1 = uri.file('/myfolder/my file first.js');
-		var modelUri2 = uri.file('/secondfolder/second/second file.js')
+		var modelUri2 = uri.file('/secondfolder/second/second file.js');
 		model.addBreakpoints([{ uri: modelUri1, lineNumber: 5, enabled: true }, { uri: modelUri1, lineNumber: 10, enabled: false }]);
 		model.addBreakpoints([{ uri: modelUri2, lineNumber: 1, enabled: true }, { uri: modelUri2, lineNumber: 2, enabled: true }, { uri: modelUri2, lineNumber: 3, enabled: false }]);
 

src/vs/workbench/parts/files/browser/views/openEditorsView.ts

@@ -24,7 +24,6 @@ import {IViewletService} from 'vs/workbench/services/viewlet/common/viewletServi
 import {Renderer, DataSource, Controller, AccessibilityProvider,  ActionProvider, OpenEditor, DragAndDrop} from 'vs/workbench/parts/files/browser/views/openEditorsViewer';
 import {IUntitledEditorService} from 'vs/workbench/services/untitled/common/untitledEditorService';
 import {CloseAllEditorsAction} from 'vs/workbench/browser/parts/editor/editorActions';
-import {IEventService} from 'vs/platform/event/common/event';
 
 const $ = dom.$;
 
@@ -49,12 +48,11 @@ export class OpenEditorsView extends AdaptiveCollapsibleViewletView {
 		@IInstantiationService private instantiationService: IInstantiationService,
 		@IContextMenuService contextMenuService: IContextMenuService,
 		@ITextFileService private textFileService: ITextFileService,
-		@IEditorGroupService private editorGroupService: IEditorGroupService,
+		@IEditorGroupService editorGroupService: IEditorGroupService,
 		@IConfigurationService private configurationService: IConfigurationService,
 		@IKeybindingService keybindingService: IKeybindingService,
 		@IUntitledEditorService private untitledEditorService: IUntitledEditorService,
-		@IViewletService private viewletService: IViewletService,
-		@IEventService private eventService: IEventService
+		@IViewletService private viewletService: IViewletService
 	) {
 		super(actionRunner, OpenEditorsView.computeExpandedBodySize(editorGroupService.getStacksModel()), !!settings[OpenEditorsView.MEMENTO_COLLAPSED], nls.localize({ key: 'openEditosrSection', comment: ['Open is an adjective'] }, "Open Editors Section"), keybindingService, contextMenuService);
 
@@ -90,7 +88,7 @@ export class OpenEditorsView extends AdaptiveCollapsibleViewletView {
 
 		const dataSource = this.instantiationService.createInstance(DataSource);
 		const actionProvider = this.instantiationService.createInstance(ActionProvider, this.model);
-		const renderer = this.instantiationService.createInstance(Renderer, actionProvider, this.model);
+		const renderer = this.instantiationService.createInstance(Renderer, actionProvider);
 		const controller = this.instantiationService.createInstance(Controller, actionProvider, this.model);
 		const accessibilityProvider = this.instantiationService.createInstance(AccessibilityProvider);
 		const dnd = this.instantiationService.createInstance(DragAndDrop);

src/vs/workbench/parts/files/browser/views/openEditorsViewer.ts

@@ -123,10 +123,7 @@ export class Renderer implements IRenderer {
 	private static EDITOR_GROUP_TEMPLATE_ID = 'editorgroup';
 	private static OPEN_EDITOR_TEMPLATE_ID = 'openeditor';
 
-	constructor(private actionProvider: ActionProvider, private model: IEditorStacksModel,
-		@ITextFileService private textFileService: ITextFileService,
-		@IInstantiationService private instantiationService: IInstantiationService,
-		@IUntitledEditorService private untitledEditorService: IUntitledEditorService
+	constructor(private actionProvider: ActionProvider, @IInstantiationService private instantiationService: IInstantiationService,
 	) {
 		// noop
 	}
@@ -198,7 +195,6 @@ export class Controller extends treedefaults.DefaultController {
 	constructor(private actionProvider: ActionProvider, private model: IEditorStacksModel,
 		@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
 		@IEditorGroupService private editorGroupService: IEditorGroupService,
-		@IInstantiationService private instantiationService: IInstantiationService,
 		@IContextMenuService private contextMenuService: IContextMenuService,
 		@ITelemetryService private telemetryService: ITelemetryService,
 		@IKeybindingService private keybindingService: IKeybindingService