Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
ea77613e
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
ea77613e
编写于
9月 03, 2018
作者:
B
Benjamin Pasero
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
debt - DOM.removeNode => node.remove()
上级
fc941ae9
变更
6
隐藏空白更改
内联
并排
Showing
6 changed file
with
12 addition
and
18 deletion
+12
-18
src/vs/base/browser/dom.ts
src/vs/base/browser/dom.ts
+0
-6
src/vs/base/browser/ui/actionbar/actionbar.ts
src/vs/base/browser/ui/actionbar/actionbar.ts
+2
-2
src/vs/base/browser/ui/dropdown/dropdown.ts
src/vs/base/browser/ui/dropdown/dropdown.ts
+4
-4
src/vs/workbench/browser/parts/compositeBarActions.ts
src/vs/workbench/browser/parts/compositeBarActions.ts
+2
-2
src/vs/workbench/browser/parts/compositePart.ts
src/vs/workbench/browser/parts/compositePart.ts
+2
-2
src/vs/workbench/browser/parts/statusbar/statusbarPart.ts
src/vs/workbench/browser/parts/statusbar/statusbarPart.ts
+2
-2
未找到文件。
src/vs/base/browser/dom.ts
浏览文件 @
ea77613e
...
...
@@ -22,12 +22,6 @@ export function clearNode(node: HTMLElement): void {
}
}
export
function
removeNode
(
node
:
HTMLElement
):
void
{
if
(
node
.
parentNode
)
{
node
.
parentNode
.
removeChild
(
node
);
}
}
export
function
isInDOM
(
node
:
Node
):
boolean
{
while
(
node
)
{
if
(
node
===
document
.
body
)
{
...
...
src/vs/base/browser/ui/actionbar/actionbar.ts
浏览文件 @
ea77613e
...
...
@@ -204,7 +204,7 @@ export class BaseActionItem extends lifecycle.Disposable implements IActionItem
public
dispose
():
void
{
if
(
this
.
element
)
{
DOM
.
removeNode
(
this
.
element
);
this
.
element
.
remove
(
);
this
.
element
=
null
;
}
...
...
@@ -751,7 +751,7 @@ export class ActionBar extends lifecycle.Disposable implements IActionRunner {
}
this
.
items
=
null
;
DOM
.
removeNode
(
this
.
getContainer
()
);
this
.
getContainer
().
remove
(
);
super
.
dispose
();
}
...
...
src/vs/base/browser/ui/dropdown/dropdown.ts
浏览文件 @
ea77613e
...
...
@@ -14,7 +14,7 @@ import { IDisposable, dispose } from 'vs/base/common/lifecycle';
import
{
IContextViewProvider
,
IAnchor
}
from
'
vs/base/browser/ui/contextview/contextview
'
;
import
{
IMenuOptions
}
from
'
vs/base/browser/ui/menu/menu
'
;
import
{
ResolvedKeybinding
}
from
'
vs/base/common/keyCodes
'
;
import
{
EventHelper
,
EventType
,
removeClass
,
addClass
,
append
,
$
,
removeNode
,
addDisposableListener
,
addClasses
}
from
'
vs/base/browser/dom
'
;
import
{
EventHelper
,
EventType
,
removeClass
,
addClass
,
append
,
$
,
addDisposableListener
,
addClasses
}
from
'
vs/base/browser/dom
'
;
import
{
IContextMenuDelegate
}
from
'
vs/base/browser/contextmenu
'
;
export
interface
ILabelRenderer
{
...
...
@@ -112,17 +112,17 @@ export class BaseDropdown extends ActionRunner {
this
.
_toDispose
=
dispose
(
this
.
toDispose
);
if
(
this
.
boxContainer
)
{
removeNode
(
this
.
boxContainer
);
this
.
boxContainer
.
remove
(
);
this
.
boxContainer
=
null
;
}
if
(
this
.
contents
)
{
removeNode
(
this
.
contents
);
this
.
contents
.
remove
(
);
this
.
contents
=
null
;
}
if
(
this
.
_label
)
{
removeNode
(
this
.
_label
);
this
.
_label
.
remove
(
);
this
.
_label
=
null
;
}
}
...
...
src/vs/workbench/browser/parts/compositeBarActions.ts
浏览文件 @
ea77613e
...
...
@@ -313,7 +313,7 @@ export class ActivityActionItem extends BaseActionItem {
clearTimeout
(
this
.
mouseUpTimeout
);
}
dom
.
removeNode
(
this
.
badge
);
this
.
badge
.
remove
(
);
}
}
...
...
@@ -622,7 +622,7 @@ export class CompositeActionItem extends ActivityActionItem {
this
.
compositeTransfer
.
clearData
(
DraggedCompositeIdentifier
.
prototype
);
dom
.
removeNode
(
this
.
label
);
this
.
label
.
remove
(
);
}
}
...
...
src/vs/workbench/browser/parts/compositePart.ts
浏览文件 @
ea77613e
...
...
@@ -34,7 +34,7 @@ import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
import
{
IThemeService
}
from
'
vs/platform/theme/common/themeService
'
;
import
{
attachProgressBarStyler
}
from
'
vs/platform/theme/common/styler
'
;
import
{
INotificationService
}
from
'
vs/platform/notification/common/notification
'
;
import
{
Dimension
,
append
,
$
,
addClass
,
hide
,
removeNode
,
show
,
addClasses
}
from
'
vs/base/browser/dom
'
;
import
{
Dimension
,
append
,
$
,
addClass
,
hide
,
show
,
addClasses
}
from
'
vs/base/browser/dom
'
;
export
interface
ICompositeTitleLabel
{
...
...
@@ -387,7 +387,7 @@ export abstract class CompositePart<T extends Composite> extends Part {
return
composite
.
setVisible
(
false
).
then
(()
=>
{
// Take Container Off-DOM and hide
removeNode
(
compositeContainer
);
compositeContainer
.
remove
(
);
hide
(
compositeContainer
);
// Clear any running Progress
...
...
src/vs/workbench/browser/parts/statusbar/statusbarPart.ts
浏览文件 @
ea77613e
...
...
@@ -27,7 +27,7 @@ import { IWorkspaceContextService, WorkbenchState } from 'vs/platform/workspace/
import
{
contrastBorder
}
from
'
vs/platform/theme/common/colorRegistry
'
;
import
{
isThemeColor
}
from
'
vs/editor/common/editorCommon
'
;
import
{
Color
}
from
'
vs/base/common/color
'
;
import
{
addClass
,
EventHelper
,
createStyleSheet
,
addDisposableListener
,
removeNode
}
from
'
vs/base/browser/dom
'
;
import
{
addClass
,
EventHelper
,
createStyleSheet
,
addDisposableListener
}
from
'
vs/base/browser/dom
'
;
import
{
INotificationService
}
from
'
vs/platform/notification/common/notification
'
;
export
class
StatusbarPart
extends
Part
implements
IStatusbarService
{
...
...
@@ -86,7 +86,7 @@ export class StatusbarPart extends Part implements IStatusbarService {
}
return
toDisposable
(()
=>
{
removeNode
(
el
);
el
.
remove
(
);
if
(
toDispose
)
{
toDispose
.
dispose
();
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录