提交 ea77613e 编写于 作者: B Benjamin Pasero

debt - DOM.removeNode => node.remove()

上级 fc941ae9
......@@ -22,12 +22,6 @@ export function clearNode(node: HTMLElement): void {
}
}
export function removeNode(node: HTMLElement): void {
if (node.parentNode) {
node.parentNode.removeChild(node);
}
}
export function isInDOM(node: Node): boolean {
while (node) {
if (node === document.body) {
......
......@@ -204,7 +204,7 @@ export class BaseActionItem extends lifecycle.Disposable implements IActionItem
public dispose(): void {
if (this.element) {
DOM.removeNode(this.element);
this.element.remove();
this.element = null;
}
......@@ -751,7 +751,7 @@ export class ActionBar extends lifecycle.Disposable implements IActionRunner {
}
this.items = null;
DOM.removeNode(this.getContainer());
this.getContainer().remove();
super.dispose();
}
......
......@@ -14,7 +14,7 @@ import { IDisposable, dispose } from 'vs/base/common/lifecycle';
import { IContextViewProvider, IAnchor } from 'vs/base/browser/ui/contextview/contextview';
import { IMenuOptions } from 'vs/base/browser/ui/menu/menu';
import { ResolvedKeybinding } from 'vs/base/common/keyCodes';
import { EventHelper, EventType, removeClass, addClass, append, $, removeNode, addDisposableListener, addClasses } from 'vs/base/browser/dom';
import { EventHelper, EventType, removeClass, addClass, append, $, addDisposableListener, addClasses } from 'vs/base/browser/dom';
import { IContextMenuDelegate } from 'vs/base/browser/contextmenu';
export interface ILabelRenderer {
......@@ -112,17 +112,17 @@ export class BaseDropdown extends ActionRunner {
this._toDispose = dispose(this.toDispose);
if (this.boxContainer) {
removeNode(this.boxContainer);
this.boxContainer.remove();
this.boxContainer = null;
}
if (this.contents) {
removeNode(this.contents);
this.contents.remove();
this.contents = null;
}
if (this._label) {
removeNode(this._label);
this._label.remove();
this._label = null;
}
}
......
......@@ -313,7 +313,7 @@ export class ActivityActionItem extends BaseActionItem {
clearTimeout(this.mouseUpTimeout);
}
dom.removeNode(this.badge);
this.badge.remove();
}
}
......@@ -622,7 +622,7 @@ export class CompositeActionItem extends ActivityActionItem {
this.compositeTransfer.clearData(DraggedCompositeIdentifier.prototype);
dom.removeNode(this.label);
this.label.remove();
}
}
......
......@@ -34,7 +34,7 @@ import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
import { IThemeService } from 'vs/platform/theme/common/themeService';
import { attachProgressBarStyler } from 'vs/platform/theme/common/styler';
import { INotificationService } from 'vs/platform/notification/common/notification';
import { Dimension, append, $, addClass, hide, removeNode, show, addClasses } from 'vs/base/browser/dom';
import { Dimension, append, $, addClass, hide, show, addClasses } from 'vs/base/browser/dom';
export interface ICompositeTitleLabel {
......@@ -387,7 +387,7 @@ export abstract class CompositePart<T extends Composite> extends Part {
return composite.setVisible(false).then(() => {
// Take Container Off-DOM and hide
removeNode(compositeContainer);
compositeContainer.remove();
hide(compositeContainer);
// Clear any running Progress
......
......@@ -27,7 +27,7 @@ import { IWorkspaceContextService, WorkbenchState } from 'vs/platform/workspace/
import { contrastBorder } from 'vs/platform/theme/common/colorRegistry';
import { isThemeColor } from 'vs/editor/common/editorCommon';
import { Color } from 'vs/base/common/color';
import { addClass, EventHelper, createStyleSheet, addDisposableListener, removeNode } from 'vs/base/browser/dom';
import { addClass, EventHelper, createStyleSheet, addDisposableListener } from 'vs/base/browser/dom';
import { INotificationService } from 'vs/platform/notification/common/notification';
export class StatusbarPart extends Part implements IStatusbarService {
......@@ -86,7 +86,7 @@ export class StatusbarPart extends Part implements IStatusbarService {
}
return toDisposable(() => {
removeNode(el);
el.remove();
if (toDispose) {
toDispose.dispose();
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册