bootstrap - fix compile errors

src/bootstrap-window.js

@@ -57,17 +57,15 @@
 			developerToolsUnbind = registerDeveloperKeybindings(options && options.disallowReloadKeybinding);
 		}
 
-		// Enable ASAR support (TODO@sandbox non-sandboxed only)
-		if (!sandbox) {
-			globalThis.MonacoBootstrap.enableASARSupport(configuration.appRoot);
-		}
+		// Enable ASAR support
+		globalThis.MonacoBootstrap.enableASARSupport(configuration.appRoot);
 
 		if (options && typeof options.canModifyDOM === 'function') {
 			options.canModifyDOM(configuration);
 		}
 
-		// Get the nls configuration into the process.env as early as possible  (TODO@sandbox non-sandboxed only)
-		const nlsConfig = sandbox ? { availableLanguages: {} } : globalThis.MonacoBootstrap.setupNLS();
+		// Get the nls configuration into the process.env as early as possible
+		const nlsConfig = globalThis.MonacoBootstrap.setupNLS();
 
 		let locale = nlsConfig.availableLanguages['*'] || 'en';
 		if (locale === 'zh-tw') {

src/bootstrap.js

@@ -46,7 +46,7 @@
 	 */
 	function enableASARSupport(appRoot) {
 		if (!path || !Module) {
-			console.warn('enableASARSupport() is only available in node.js environments');
+			console.warn('enableASARSupport() is only available in node.js environments'); // TODO@sandbox ASAR is currently non-sandboxed only
 			return;
 		}
 
@@ -129,7 +129,7 @@
 	function setupNLS() {
 		if (!path || !fs) {
 			console.warn('setupNLS() is only available in node.js environments');
-			return;
+			return { availableLanguages: {} }; // TODO@sandbox NLS is currently non-sandboxed only
 		}
 
 		// Get the nls configuration into the process.env as early as possible.
@@ -185,13 +185,16 @@
 	 */
 	function configurePortable(product) {
 		if (!path || !fs) {
-			console.warn('configurePortable() is only available in node.js environments');
+			console.warn('configurePortable() is only available in node.js environments'); // TODO@sandbox Portable is currently non-sandboxed only
 			return;
 		}
 
 		const appRoot = path.dirname(__dirname);
 
-		function getApplicationPath() {
+		/**
+		 * @param {import('path')} path
+		 */
+		function getApplicationPath(path) {
 			if (process.env['VSCODE_DEV']) {
 				return appRoot;
 			}
@@ -203,21 +206,24 @@
 			return path.dirname(path.dirname(appRoot));
 		}
 
-		function getPortableDataPath() {
+		/**
+		 * @param {import('path')} path
+		 */
+		function getPortableDataPath(path) {
 			if (process.env['VSCODE_PORTABLE']) {
 				return process.env['VSCODE_PORTABLE'];
 			}
 
 			if (process.platform === 'win32' || process.platform === 'linux') {
-				return path.join(getApplicationPath(), 'data');
+				return path.join(getApplicationPath(path), 'data');
 			}
 
 			// @ts-ignore
 			const portableDataName = product.portable || `${product.applicationName}-portable-data`;
-			return path.join(path.dirname(getApplicationPath()), portableDataName);
+			return path.join(path.dirname(getApplicationPath(path)), portableDataName);
 		}
 
-		const portableDataPath = getPortableDataPath();
+		const portableDataPath = getPortableDataPath(path);
 		const isPortable = !('target' in product) && fs.existsSync(portableDataPath);
 		const portableTempPath = path.join(portableDataPath, 'tmp');
 		const isTempPortable = isPortable && fs.existsSync(portableTempPath);