Skip to content

V
vscode

xxadev / vscode
与 Fork 源项目一致

从无法访问的项目Fork

通知 2
Star 0
Fork 0
V
vscode

体验新版 GitCode，发现更多精彩内容 >>

提交 e8b20966 编写于 作者: M Matt Bierner
浏览文件
操作

Use DisposableStore

上级 565cadac
隐藏空白更改
内联 并排
Showing with 6 addition and 6 deletion
src/vs/workbench/contrib/preferences/browser/keybindingWidgets.ts
浏览文件 @ e8b20966
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
import 'vs/css!./media/keybindings'; import 'vs/css!./media/keybindings';
import * as nls from 'vs/nls'; import * as nls from 'vs/nls';
import { OS } from 'vs/base/common/platform'; import { OS } from 'vs/base/common/platform';
import { Disposable, dispose, toDisposable, IDisposable } from 'vs/base/common/lifecycle'; import { Disposable, toDisposable, DisposableStore } from 'vs/base/common/lifecycle';
import { Event, Emitter } from 'vs/base/common/event'; import { Event, Emitter } from 'vs/base/common/event';
import { KeybindingLabel } from 'vs/base/browser/ui/keybindingLabel/keybindingLabel'; import { KeybindingLabel } from 'vs/base/browser/ui/keybindingLabel/keybindingLabel';
import { Widget } from 'vs/base/browser/ui/widget'; import { Widget } from 'vs/base/browser/ui/widget';
...@@ -36,7 +36,7 @@ export class KeybindingsSearchWidget extends SearchWidget { ...@@ -36,7 +36,7 @@ export class KeybindingsSearchWidget extends SearchWidget {
private _chordPart: ResolvedKeybinding | null; private _chordPart: ResolvedKeybinding | null;
private _inputValue: string; private _inputValue: string;
private recordDisposables: IDisposable[] = []; private readonly recordDisposables = this._register(new DisposableStore());
private _onKeybinding = this._register(new Emitter<[ResolvedKeybinding | null, ResolvedKeybinding | null]>()); private _onKeybinding = this._register(new Emitter<[ResolvedKeybinding | null, ResolvedKeybinding | null]>());
readonly onKeybinding: Event<[ResolvedKeybinding | null, ResolvedKeybinding | null]> = this._onKeybinding.event; readonly onKeybinding: Event<[ResolvedKeybinding | null, ResolvedKeybinding | null]> = this._onKeybinding.event;
...@@ -69,9 +69,9 @@ export class KeybindingsSearchWidget extends SearchWidget { ...@@ -69,9 +69,9 @@ export class KeybindingsSearchWidget extends SearchWidget {
} }
startRecordingKeys(): void { startRecordingKeys(): void {
this.recordDisposables.push(dom.addDisposableListener(this.inputBox.inputElement, dom.EventType.KEY_DOWN, (e: KeyboardEvent) => this._onKeyDown(new StandardKeyboardEvent(e)))); this.recordDisposables.add(dom.addDisposableListener(this.inputBox.inputElement, dom.EventType.KEY_DOWN, (e: KeyboardEvent) => this._onKeyDown(new StandardKeyboardEvent(e))));
this.recordDisposables.push(dom.addDisposableListener(this.inputBox.inputElement, dom.EventType.BLUR, () => this._onBlur.fire())); this.recordDisposables.add(dom.addDisposableListener(this.inputBox.inputElement, dom.EventType.BLUR, () => this._onBlur.fire()));
this.recordDisposables.push(dom.addDisposableListener(this.inputBox.inputElement, dom.EventType.INPUT, () => { this.recordDisposables.add(dom.addDisposableListener(this.inputBox.inputElement, dom.EventType.INPUT, () => {
// Prevent other characters from showing up // Prevent other characters from showing up
this.setInputValue(this._inputValue); this.setInputValue(this._inputValue);
})); }));
...@@ -79,7 +79,7 @@ export class KeybindingsSearchWidget extends SearchWidget { ...@@ -79,7 +79,7 @@ export class KeybindingsSearchWidget extends SearchWidget {
stopRecordingKeys(): void { stopRecordingKeys(): void {
this._reset(); this._reset();
dispose(this.recordDisposables); this.recordDisposables.dispose();
} }
setInputValue(value: string): void { setInputValue(value: string): void {
......
Markdown is supported
0% 或 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑！
想要评论请 注册 或