提交 e49d3872 编写于 作者: J Johannes Rieken

fix #89596

上级 efa12b2f
...@@ -42,6 +42,7 @@ export class EditorBreadcrumbsModel { ...@@ -42,6 +42,7 @@ export class EditorBreadcrumbsModel {
private readonly _disposables = new DisposableStore(); private readonly _disposables = new DisposableStore();
private readonly _fileInfo: FileInfo; private readonly _fileInfo: FileInfo;
private readonly _cfgEnabled: BreadcrumbsConfig<boolean>;
private readonly _cfgFilePath: BreadcrumbsConfig<'on' | 'off' | 'last'>; private readonly _cfgFilePath: BreadcrumbsConfig<'on' | 'off' | 'last'>;
private readonly _cfgSymbolPath: BreadcrumbsConfig<'on' | 'off' | 'last'>; private readonly _cfgSymbolPath: BreadcrumbsConfig<'on' | 'off' | 'last'>;
...@@ -58,6 +59,7 @@ export class EditorBreadcrumbsModel { ...@@ -58,6 +59,7 @@ export class EditorBreadcrumbsModel {
@ITextResourceConfigurationService private readonly _textResourceConfigurationService: ITextResourceConfigurationService, @ITextResourceConfigurationService private readonly _textResourceConfigurationService: ITextResourceConfigurationService,
@IWorkspaceContextService workspaceService: IWorkspaceContextService, @IWorkspaceContextService workspaceService: IWorkspaceContextService,
) { ) {
this._cfgEnabled = BreadcrumbsConfig.IsEnabled.bindTo(_configurationService);
this._cfgFilePath = BreadcrumbsConfig.FilePath.bindTo(_configurationService); this._cfgFilePath = BreadcrumbsConfig.FilePath.bindTo(_configurationService);
this._cfgSymbolPath = BreadcrumbsConfig.SymbolPath.bindTo(_configurationService); this._cfgSymbolPath = BreadcrumbsConfig.SymbolPath.bindTo(_configurationService);
...@@ -69,6 +71,7 @@ export class EditorBreadcrumbsModel { ...@@ -69,6 +71,7 @@ export class EditorBreadcrumbsModel {
} }
dispose(): void { dispose(): void {
this._cfgEnabled.dispose();
this._cfgFilePath.dispose(); this._cfgFilePath.dispose();
this._cfgSymbolPath.dispose(); this._cfgSymbolPath.dispose();
this._outlineDisposables.dispose(); this._outlineDisposables.dispose();
...@@ -144,6 +147,11 @@ export class EditorBreadcrumbsModel { ...@@ -144,6 +147,11 @@ export class EditorBreadcrumbsModel {
// update when config changes (re-render) // update when config changes (re-render)
this._disposables.add(this._configurationService.onDidChangeConfiguration(e => { this._disposables.add(this._configurationService.onDidChangeConfiguration(e => {
if (!this._cfgEnabled.getValue()) {
// breadcrumbs might be disabled (also via a setting/config) and that is
// something we must check before proceeding.
return;
}
if (e.affectsConfiguration('breadcrumbs')) { if (e.affectsConfiguration('breadcrumbs')) {
this._updateOutline(true); this._updateOutline(true);
return; return;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册