Add use conpty setting

src/vs/workbench/api/node/extHostTerminalService.ts

@@ -406,7 +406,7 @@ export class ExtHostTerminalService implements ExtHostTerminalServiceShape {
 
 		// Fork the process and listen for messages
 		this._logService.debug(`Terminal process launching on ext host`, shellLaunchConfig, initialCwd, cols, rows, env);
-		this._terminalProcesses[id] = new TerminalProcess(shellLaunchConfig, initialCwd, cols, rows, env);
+		this._terminalProcesses[id] = new TerminalProcess(shellLaunchConfig, initialCwd, cols, rows, env, terminalConfig.get('experimentalUseConpty'));
 		this._terminalProcesses[id].onProcessIdReady(pid => this._proxy.$sendProcessPid(id, pid));
 		this._terminalProcesses[id].onProcessTitleChanged(title => this._proxy.$sendProcessTitle(id, title));
 		this._terminalProcesses[id].onProcessData(data => this._proxy.$sendProcessData(id, data));

src/vs/workbench/parts/terminal/common/terminal.ts

@@ -102,6 +102,7 @@ export interface ITerminalConfiguration {
 	showExitAlert: boolean;
 	experimentalBufferImpl: 'JsArray' | 'TypedArray';
 	splitCwd: 'workspaceRoot' | 'initial' | 'inherited';
+	experimentalUseConpty: boolean;
 }
 
 export interface ITerminalConfigHelper {

src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts

@@ -397,6 +397,11 @@ configurationRegistry.registerConfiguration({
 			],
 			default: 'inherited'
 		},
+		'terminal.integrated.experimentalUseConpty': {
+			description: nls.localize('terminal.integrated.experimentalUseConpty', "Whether to enable conpty on Windows 10 (needs >= 17692). Winpty will be used if this is false."),
+			type: 'boolean',
+			default: false
+		}
 	}
 });
 

src/vs/workbench/parts/terminal/electron-browser/terminalProcessManager.ts

@@ -122,7 +122,7 @@ export class TerminalProcessManager implements ITerminalProcessManager {
 			terminalEnvironment.addTerminalEnvironmentKeys(env, locale);
 
 			this._logService.debug(`Terminal process launching`, shellLaunchConfig, this.initialCwd, cols, rows, env);
-			this._process = new TerminalProcess(shellLaunchConfig, this.initialCwd, cols, rows, env);
+			this._process = new TerminalProcess(shellLaunchConfig, this.initialCwd, cols, rows, env, this._configHelper.config.experimentalUseConpty);
 		}
 		this.processState = ProcessState.LAUNCHING;
 

src/vs/workbench/parts/terminal/node/terminalProcess.ts

@@ -35,7 +35,8 @@ export class TerminalProcess implements ITerminalChildProcess, IDisposable {
 		cwd: string,
 		cols: number,
 		rows: number,
-		env: platform.IProcessEnvironment
+		env: platform.IProcessEnvironment,
+		useConpty: boolean
 	) {
 		let shellName: string;
 		if (os.platform() === 'win32') {