Strict null check webview

src/tsconfig.strictNullChecks.json

@@ -29,7 +29,8 @@
 		"./vs/workbench/services/bulkEdit/**/*.ts",
 		"./vs/workbench/services/progress/**/*.ts",
 		"./vs/workbench/services/preferences/**/*.ts",
-		"./vs/workbench/services/timer/**/*.ts"
+		"./vs/workbench/services/timer/**/*.ts",
+		"./vs/workbench/contrib/webview/**/*.ts"
 	],
 	"files": [
 		"./vs/monaco.d.ts",
@@ -238,8 +239,10 @@
 		"./vs/workbench/contrib/extensions/common/extensionsFileTemplate.ts",
 		"./vs/workbench/contrib/extensions/common/extensionsInput.ts",
 		"./vs/workbench/contrib/extensions/common/extensionsUtils.ts",
+		"./vs/workbench/contrib/extensions/electron-browser/extensionEditor.ts",
 		"./vs/workbench/contrib/extensions/electron-browser/extensionProfileService.ts",
 		"./vs/workbench/contrib/extensions/electron-browser/extensionTipsService.ts",
+		"./vs/workbench/contrib/extensions/electron-browser/extensions.contribution.ts",
 		"./vs/workbench/contrib/extensions/electron-browser/extensionsActions.ts",
 		"./vs/workbench/contrib/extensions/electron-browser/extensionsActivationProgress.ts",
 		"./vs/workbench/contrib/extensions/electron-browser/extensionsAutoProfiler.ts",
@@ -370,8 +373,10 @@
 		"./vs/workbench/contrib/terminal/test/node/terminalEnvironment.test.ts",
 		"./vs/workbench/contrib/themes/browser/themes.contribution.ts",
 		"./vs/workbench/contrib/themes/test/electron-browser/themes.test.contribution.ts",
+		"./vs/workbench/contrib/update/electron-browser/releaseNotesEditor.ts",
+		"./vs/workbench/contrib/update/electron-browser/update.contribution.ts",
+		"./vs/workbench/contrib/update/electron-browser/update.ts",
 		"./vs/workbench/contrib/url/common/url.contribution.ts",
-		"./vs/workbench/contrib/webview/electron-browser/webviewProtocols.ts",
 		"./vs/workbench/electron-browser/window.ts",
 		"./vs/workbench/services/activity/browser/activityService.ts",
 		"./vs/workbench/services/activity/common/activity.ts",

src/vs/workbench/contrib/webview/electron-browser/webviewEditorService.ts

@@ -12,6 +12,7 @@ import * as vscode from 'vscode';
 import { WebviewEditorInput, RevivedWebviewEditorInput } from './webviewEditorInput';
 import { GroupIdentifier } from 'vs/workbench/common/editor';
 import { equals } from 'vs/base/common/arrays';
+import { values } from 'vs/base/common/map';
 
 export const IWebviewEditorService = createDecorator<IWebviewEditorService>('webviewEditorService');
 
@@ -169,7 +170,7 @@ export class WebviewEditorService implements IWebviewEditorService {
 	canRevive(
 		webview: WebviewEditorInput
 	): boolean {
-		for (const reviver of this._revivers) {
+		for (const reviver of values(this._revivers)) {
 			if (reviver.canRevive(webview)) {
 				return true;
 			}
@@ -180,7 +181,7 @@ export class WebviewEditorService implements IWebviewEditorService {
 	private async tryRevive(
 		webview: WebviewEditorInput
 	): Promise<boolean> {
-		for (const reviver of this._revivers) {
+		for (const reviver of values(this._revivers)) {
 			if (reviver.canRevive(webview)) {
 				await reviver.reviveWebview(webview);
 				return true;