Customizable menu seperator color (#58498)

* remove unused CSS

* Customizable menu seperator color (fixes #56730)

* change wording

src/vs/workbench/browser/parts/titlebar/menubarControl.ts

@@ -28,7 +28,7 @@ import { domEvent } from 'vs/base/browser/event';
 import { IRecentlyOpened } from 'vs/platform/history/common/history';
 import { IWorkspaceIdentifier, ISingleFolderWorkspaceIdentifier, isSingleFolderWorkspaceIdentifier, isWorkspaceIdentifier } from 'vs/platform/workspaces/common/workspaces';
 import { RunOnceScheduler } from 'vs/base/common/async';
-import { MENUBAR_SELECTION_FOREGROUND, MENUBAR_SELECTION_BACKGROUND, MENUBAR_SELECTION_BORDER, TITLE_BAR_ACTIVE_FOREGROUND, TITLE_BAR_INACTIVE_FOREGROUND, MENU_BACKGROUND, MENU_FOREGROUND, MENU_SELECTION_BACKGROUND, MENU_SELECTION_FOREGROUND, MENU_SELECTION_BORDER } from 'vs/workbench/common/theme';
+import { MENUBAR_SELECTION_FOREGROUND, MENUBAR_SELECTION_BACKGROUND, MENUBAR_SELECTION_BORDER, TITLE_BAR_ACTIVE_FOREGROUND, TITLE_BAR_INACTIVE_FOREGROUND, MENU_BACKGROUND, MENU_FOREGROUND, MENU_SELECTION_BACKGROUND, MENU_SELECTION_FOREGROUND, MENU_SELECTION_BORDER, MENUBAR_SEPARATOR_BACKGROUND } from 'vs/workbench/common/theme';
 import { URI } from 'vs/base/common/uri';
 import { ILabelService } from 'vs/platform/label/common/label';
 import { foreground } from 'vs/platform/theme/common/colorRegistry';
@@ -1276,6 +1276,15 @@ registerThemingParticipant((theme: ITheme, collector: ICssStyleCollector) => {
 			}
 		`);
 	}
+
+	const menuItemSeparatorBackground = theme.getColor(MENUBAR_SEPARATOR_BACKGROUND);
+	if (menuItemSeparatorBackground) {
+		collector.addRule(`
+		.monaco-shell .monaco-menu .monaco-action-bar.vertical .action-label.separator {
+				border-bottom: 1px solid ${menuItemSeparatorBackground};
+			}
+		`);
+	}
 });
 
 type ModifierKey = 'alt' | 'ctrl' | 'shift';

src/vs/workbench/common/theme.ts

@@ -449,6 +449,12 @@ export const MENU_SELECTION_BORDER = registerColor('menu.selectionBorder', {
 	hc: null
 }, nls.localize('menuSelectionBorder', "Border color of the selected menu item in menus."));
 
+export const MENUBAR_SEPARATOR_BACKGROUND = registerColor('menu.separatorBackground', {
+	dark: '#BBBBBB',
+	light: '#888888',
+	hc: contrastBorder
+}, nls.localize('menuSeparatorBackground', "Color of a separator menu item in menus."));
+
 // < --- Notifications --- >
 
 export const NOTIFICATIONS_CENTER_BORDER = registerColor('notificationCenter.border', {