Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
d2bc3a07
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
d2bc3a07
编写于
11月 22, 2018
作者:
J
Johannes Rieken
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
remove unused and duplicated code
上级
66bcd337
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
3 addition
and
25 deletion
+3
-25
src/vs/base/common/collections.ts
src/vs/base/common/collections.ts
+0
-12
src/vs/base/common/objects.ts
src/vs/base/common/objects.ts
+1
-6
src/vs/base/test/common/collections.test.ts
src/vs/base/test/common/collections.test.ts
+0
-5
src/vs/platform/extensionManagement/node/extensionGalleryService.ts
...tform/extensionManagement/node/extensionGalleryService.ts
+2
-2
未找到文件。
src/vs/base/common/collections.ts
浏览文件 @
d2bc3a07
...
...
@@ -71,18 +71,6 @@ export function forEach<T>(from: IStringDictionary<T> | INumberDictionary<T>, ca
}
}
/**
* Removes an element from the dictionary. Returns {{false}} if the property
* does not exists.
*/
export
function
remove
<
T
>
(
from
:
IStringDictionary
<
T
>
|
INumberDictionary
<
T
>
,
key
:
string
):
boolean
{
if
(
!
hasOwnProperty
.
call
(
from
,
key
))
{
return
false
;
}
delete
(
from
as
any
)[
key
];
return
true
;
}
/**
* Groups the collection into a dictionary based on the provided
* group function.
...
...
src/vs/base/common/objects.ts
浏览文件 @
d2bc3a07
...
...
@@ -171,7 +171,7 @@ export function equals(one: any, other: any): boolean {
return
true
;
}
export
function
arrayToHash
(
array
:
any
[])
{
function
arrayToHash
(
array
:
string
[]):
{
[
name
:
string
]:
true
}
{
const
result
:
any
=
{};
for
(
let
i
=
0
;
i
<
array
.
length
;
++
i
)
{
result
[
array
[
i
]]
=
true
;
...
...
@@ -218,11 +218,6 @@ export function safeStringify(obj: any): string {
});
}
export
function
getOrDefault
<
T
,
R
>
(
obj
:
T
,
fn
:
(
obj
:
T
)
=>
R
,
defaultValue
:
R
|
null
=
null
):
R
|
null
{
const
result
=
fn
(
obj
);
return
typeof
result
===
'
undefined
'
?
defaultValue
:
result
;
}
export
function
getOrDefault2
<
T
,
R
>
(
obj
:
T
,
fn
:
(
obj
:
T
)
=>
R
|
undefined
,
defaultValue
:
R
):
R
{
const
result
=
fn
(
obj
);
return
typeof
result
===
'
undefined
'
?
defaultValue
:
result
;
...
...
src/vs/base/test/common/collections.test.ts
浏览文件 @
d2bc3a07
...
...
@@ -54,9 +54,4 @@ suite('Collections', () => {
assert
.
equal
(
grouped
[
group2
].
length
,
1
);
assert
.
equal
(
grouped
[
group2
][
0
].
value
,
value3
);
});
test
(
'
remove
'
,
()
=>
{
assert
(
collections
.
remove
({
'
far
'
:
1
},
'
far
'
));
assert
(
!
collections
.
remove
({
'
far
'
:
1
},
'
boo
'
));
});
});
src/vs/platform/extensionManagement/node/extensionGalleryService.ts
浏览文件 @
d2bc3a07
...
...
@@ -9,7 +9,7 @@ import { distinct } from 'vs/base/common/arrays';
import
{
getErrorMessage
,
isPromiseCanceledError
,
canceled
}
from
'
vs/base/common/errors
'
;
import
{
StatisticType
,
IGalleryExtension
,
IExtensionGalleryService
,
IGalleryExtensionAsset
,
IQueryOptions
,
SortBy
,
SortOrder
,
IExtensionManifest
,
IExtensionIdentifier
,
IReportedExtension
,
InstallOperation
,
ITranslation
}
from
'
vs/platform/extensionManagement/common/extensionManagement
'
;
import
{
getGalleryExtensionId
,
getGalleryExtensionTelemetryData
,
adoptToGalleryExtensionId
}
from
'
vs/platform/extensionManagement/common/extensionManagementUtil
'
;
import
{
assign
,
getOrDefault
}
from
'
vs/base/common/objects
'
;
import
{
assign
,
getOrDefault
2
}
from
'
vs/base/common/objects
'
;
import
{
IRequestService
}
from
'
vs/platform/request/node/request
'
;
import
{
ITelemetryService
}
from
'
vs/platform/telemetry/common/telemetry
'
;
import
{
IPager
}
from
'
vs/base/common/paging
'
;
...
...
@@ -402,7 +402,7 @@ export class ExtensionGalleryService implements IExtensionGalleryService {
const
type
=
options
.
names
?
'
ids
'
:
(
options
.
text
?
'
text
'
:
'
all
'
);
let
text
=
options
.
text
||
''
;
const
pageSize
=
getOrDefault
(
options
,
o
=>
o
.
pageSize
,
50
);
const
pageSize
=
getOrDefault
2
(
options
,
o
=>
o
.
pageSize
,
50
);
/* __GDPR__
"galleryService:query" : {
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录