Fix #53445 - only run getSettingsSearchBuildId on official builds

build/gulpfile.vscode.js

@@ -268,10 +268,8 @@ function packageTask(platform, arch, opts) {
 		const date = new Date().toISOString();
 		const productJsonUpdate = { commit, date, checksums };
 
-		try {
+		if (shouldSetupSettingsSearch()) {
 			productJsonUpdate.settingsSearchBuildId = getSettingsSearchBuildId(packageJson);
-		} catch (err) {
-			console.warn(err);
 		}
 
 		const productJsonStream = gulp.src(['product.json'], { base: '.' })
@@ -470,9 +468,9 @@ gulp.task('upload-vscode-sourcemaps', ['minify-vscode'], () => {
 
 const allConfigDetailsPath = path.join(os.tmpdir(), 'configuration.json');
 gulp.task('upload-vscode-configuration', ['generate-vscode-configuration'], () => {
-	const branch = process.env.BUILD_SOURCEBRANCH;
 
-	if (!/\/master$/.test(branch) && branch.indexOf('/release/') < 0) {
+	if (!shouldSetupSettingsSearch()) {
+		const branch = process.env.BUILD_SOURCEBRANCH;
 		console.log(`Only runs on master and release branches, not ${branch}`);
 		return;
 	}
@@ -495,6 +493,11 @@ gulp.task('upload-vscode-configuration', ['generate-vscode-configuration'], () =
 		}));
 });
 
+function shouldSetupSettingsSearch() {
+	const branch = process.env.BUILD_SOURCEBRANCH;
+	return typeof branch === 'string' && (/\/master$/.test(branch) || branch.indexOf('/release/') >= 0);
+}
+
 function getSettingsSearchBuildId(packageJson) {
 	const previous = util.getPreviousVersion(packageJson.version);