Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
c082cc53
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
c082cc53
编写于
12月 01, 2016
作者:
K
kieferrm
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
opt-out telemetry; fixes #16131
上级
dce380bc
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
8 addition
and
13 deletion
+8
-13
src/vs/platform/telemetry/common/telemetryService.ts
src/vs/platform/telemetry/common/telemetryService.ts
+2
-2
src/vs/platform/telemetry/test/electron-browser/telemetryService.test.ts
.../telemetry/test/electron-browser/telemetryService.test.ts
+6
-11
未找到文件。
src/vs/platform/telemetry/common/telemetryService.ts
浏览文件 @
c082cc53
...
...
@@ -100,8 +100,8 @@ export class TelemetryService implements ITelemetryService {
}
publicLog
(
eventName
:
string
,
data
?:
any
):
TPromise
<
any
>
{
// don't send events when the user is optout
unless the event is the opt{in|out} signal
if
(
!
this
.
_userOptIn
&&
eventName
!==
'
optInStatus
'
)
{
// don't send events when the user is optout
if
(
!
this
.
_userOptIn
)
{
return
TPromise
.
as
(
undefined
);
}
...
...
src/vs/platform/telemetry/test/electron-browser/telemetryService.test.ts
浏览文件 @
c082cc53
...
...
@@ -639,27 +639,22 @@ suite('TelemetryService', () => {
});
}));
test
(
'
Telemetry Service
sends events when enableTelemetry is on even user optin is on
'
,
sinon
.
test
(
function
()
{
test
(
'
Telemetry Service
does not sent optInStatus when user opted out
'
,
sinon
.
test
(
function
()
{
let
testAppender
=
new
TestTelemetryAppender
();
let
service
=
new
TelemetryService
({
userOptIn
:
tru
e
,
appender
:
testAppender
},
undefined
);
let
service
=
new
TelemetryService
({
userOptIn
:
fals
e
,
appender
:
testAppender
},
undefined
);
return
service
.
publicLog
(
'
testEvent
'
).
then
(()
=>
{
assert
.
equal
(
testAppender
.
getEventsCount
(),
1
);
return
service
.
publicLog
(
optInStatusEventName
,
{
optIn
:
false
}
).
then
(()
=>
{
assert
.
equal
(
testAppender
.
getEventsCount
(),
0
);
service
.
dispose
();
});
}));
test
(
'
Telemetry Service
allows optin friendly events
'
,
sinon
.
test
(
function
()
{
test
(
'
Telemetry Service
sends events when enableTelemetry is on even user optin is on
'
,
sinon
.
test
(
function
()
{
let
testAppender
=
new
TestTelemetryAppender
();
let
service
=
new
TelemetryService
({
userOptIn
:
fals
e
,
appender
:
testAppender
},
undefined
);
let
service
=
new
TelemetryService
({
userOptIn
:
tru
e
,
appender
:
testAppender
},
undefined
);
return
service
.
publicLog
(
'
testEvent
'
).
then
(()
=>
{
assert
.
equal
(
testAppender
.
getEventsCount
(),
0
);
return
service
.
publicLog
(
optInStatusEventName
,
{
userOptIn
:
false
});
}).
then
(()
=>
{
assert
.
equal
(
testAppender
.
getEventsCount
(),
1
);
assert
.
equal
(
testAppender
.
events
[
0
].
eventName
,
optInStatusEventName
);
assert
.
equal
(
testAppender
.
events
[
0
].
data
.
userOptIn
,
false
);
service
.
dispose
();
});
}));
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录