Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
bd0e7a80
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
bd0e7a80
编写于
5月 31, 2018
作者:
B
Benjamin Pasero
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
grid - todo@grid => todo@ben
上级
18493986
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
5 addition
and
9 deletion
+5
-9
src/vs/workbench/browser/parts/editor/editorPart.ts
src/vs/workbench/browser/parts/editor/editorPart.ts
+4
-8
src/vs/workbench/electron-browser/workbench.ts
src/vs/workbench/electron-browser/workbench.ts
+1
-1
未找到文件。
src/vs/workbench/browser/parts/editor/editorPart.ts
浏览文件 @
bd0e7a80
...
@@ -34,10 +34,6 @@ import { ILifecycleService, LifecyclePhase } from 'vs/platform/lifecycle/common/
...
@@ -34,10 +34,6 @@ import { ILifecycleService, LifecyclePhase } from 'vs/platform/lifecycle/common/
import
{
EditorDropTarget
}
from
'
vs/workbench/browser/parts/editor/editorDropTarget
'
;
import
{
EditorDropTarget
}
from
'
vs/workbench/browser/parts/editor/editorDropTarget
'
;
import
{
localize
}
from
'
vs/nls
'
;
import
{
localize
}
from
'
vs/nls
'
;
// TODO@grid enable minimized/maximized groups in one dimension
// - doCreateGroupView(): needs listener if the view gets minimized, the previous active group should become active
// - doSetGroupActive(): needs a listener if the group is minimized, it should now restore to be maximized
interface
IEditorPartUIState
{
interface
IEditorPartUIState
{
serializedGrid
:
ISerializedGrid
;
serializedGrid
:
ISerializedGrid
;
activeGroup
:
GroupIdentifier
;
activeGroup
:
GroupIdentifier
;
...
@@ -237,7 +233,7 @@ export class EditorPart extends Part implements IEditorGroupsServiceImpl, IEdito
...
@@ -237,7 +233,7 @@ export class EditorPart extends Part implements IEditorGroupsServiceImpl, IEdito
const
neighbourGroupView
=
groups
[
direction
===
GroupDirection
.
RIGHT
||
direction
===
GroupDirection
.
DOWN
?
index
+
1
:
index
-
1
];
const
neighbourGroupView
=
groups
[
direction
===
GroupDirection
.
RIGHT
||
direction
===
GroupDirection
.
DOWN
?
index
+
1
:
index
-
1
];
if
(
neighbourGroupView
&&
this
.
gridWidget
.
getOrientation
(
neighbourGroupView
)
===
this
.
gridWidget
.
getOrientation
(
sourceGroupView
))
{
if
(
neighbourGroupView
&&
this
.
gridWidget
.
getOrientation
(
neighbourGroupView
)
===
this
.
gridWidget
.
getOrientation
(
sourceGroupView
))
{
return
neighbourGroupView
;
// TODO@
grid
finding neighbour needs gridwidget support
return
neighbourGroupView
;
// TODO@
ben
finding neighbour needs gridwidget support
}
}
return
void
0
;
return
void
0
;
...
@@ -781,7 +777,7 @@ export class EditorPart extends Part implements IEditorGroupsServiceImpl, IEdito
...
@@ -781,7 +777,7 @@ export class EditorPart extends Part implements IEditorGroupsServiceImpl, IEdito
this
.
_activeGroup
=
void
0
;
this
.
_activeGroup
=
void
0
;
this
.
mostRecentActiveGroups
=
[];
this
.
mostRecentActiveGroups
=
[];
this
.
gridError
(
error
);
// TODO@
grid
remove this safe guard once the grid is stable
this
.
gridError
(
error
);
// TODO@
ben
remove this safe guard once the grid is stable
}
}
}
}
}
}
...
@@ -911,7 +907,7 @@ export class EditorPart extends Part implements IEditorGroupsServiceImpl, IEdito
...
@@ -911,7 +907,7 @@ export class EditorPart extends Part implements IEditorGroupsServiceImpl, IEdito
return
this
.
groupViews
.
size
===
1
&&
this
.
_activeGroup
.
isEmpty
();
return
this
.
groupViews
.
size
===
1
&&
this
.
_activeGroup
.
isEmpty
();
}
}
// TODO@
grid
this should be removed once the gridwidget is stable
// TODO@
ben
this should be removed once the gridwidget is stable
private
gridError
(
error
:
Error
):
void
{
private
gridError
(
error
:
Error
):
void
{
console
.
error
(
error
);
console
.
error
(
error
);
...
@@ -977,7 +973,7 @@ export class EditorPart extends Part implements IEditorGroupsServiceImpl, IEdito
...
@@ -977,7 +973,7 @@ export class EditorPart extends Part implements IEditorGroupsServiceImpl, IEdito
//#endregion
//#endregion
}
}
// Group borders (TODO@
grid
this should be a color the GridView exposes)
// Group borders (TODO@
ben
this should be a color the GridView exposes)
registerThemingParticipant
((
theme
,
collector
)
=>
{
registerThemingParticipant
((
theme
,
collector
)
=>
{
const
groupBorderColor
=
theme
.
getColor
(
EDITOR_GROUP_BORDER
)
||
theme
.
getColor
(
contrastBorder
);
const
groupBorderColor
=
theme
.
getColor
(
EDITOR_GROUP_BORDER
)
||
theme
.
getColor
(
contrastBorder
);
if
(
groupBorderColor
)
{
if
(
groupBorderColor
)
{
...
...
src/vs/workbench/electron-browser/workbench.ts
浏览文件 @
bd0e7a80
...
@@ -1247,7 +1247,7 @@ export class Workbench extends Disposable implements IPartService {
...
@@ -1247,7 +1247,7 @@ export class Workbench extends Disposable implements IPartService {
return
this
.
centeredEditorLayoutActive
;
return
this
.
centeredEditorLayoutActive
;
}
}
// TODO@
grid
support centered editor layout using empty groups or not? functionality missing:
// TODO@
ben
support centered editor layout using empty groups or not? functionality missing:
// - resize sashes left and right in sync
// - resize sashes left and right in sync
// - IEditorInput.supportsCenteredEditorLayout() no longer supported
// - IEditorInput.supportsCenteredEditorLayout() no longer supported
// - should we just allow to enter layout even if groups > 1? what does it then mean to be
// - should we just allow to enter layout even if groups > 1? what does it then mean to be
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录