Strict null check viewlet

src/tsconfig.strictNullChecks.json

@@ -546,6 +546,7 @@
 		"./vs/workbench/browser/parts/quickopen/quickopen.ts",
 		"./vs/workbench/browser/parts/statusbar/statusbar.ts",
 		"./vs/workbench/browser/parts/statusbar/statusbarPart.ts",
+		"./vs/workbench/browser/viewlet.ts",
 		"./vs/workbench/common/actions.ts",
 		"./vs/workbench/common/activity.ts",
 		"./vs/workbench/common/component.ts",
@@ -639,6 +640,7 @@
 		"./vs/workbench/parts/search/browser/patternInputWidget.ts",
 		"./vs/workbench/parts/search/browser/replaceContributions.ts",
 		"./vs/workbench/parts/search/browser/replaceService.ts",
+		"./vs/workbench/parts/search/browser/searchViewLocationUpdater.ts",
 		"./vs/workbench/parts/search/common/constants.ts",
 		"./vs/workbench/parts/search/common/queryBuilder.ts",
 		"./vs/workbench/parts/search/common/replace.ts",
@@ -844,7 +846,9 @@
 		"./vs/workbench/services/themes/electron-browser/fileIconThemeData.ts",
 		"./vs/workbench/services/themes/electron-browser/fileIconThemeStore.ts",
 		"./vs/workbench/services/title/common/titleService.ts",
+		"./vs/workbench/services/viewlet/browser/viewlet.ts",
 		"./vs/workbench/services/workspace/common/workspaceEditing.ts",
+		"./vs/workbench/test/browser/viewlet.test.ts",
 		"./vs/workbench/test/common/editor/editorOptions.test.ts",
 		"./vs/workbench/test/common/notifications.test.ts",
 		"./vs/workbench/test/electron-browser/api/extHostTypes.test.ts",

src/vs/workbench/browser/viewlet.ts

@@ -35,7 +35,7 @@ export abstract class Viewlet extends Composite implements IViewlet {
 		super(id, telemetryService, themeService, storageService);
 	}
 
-	getOptimalWidth(): number {
+	getOptimalWidth(): number | null {
 		return null;
 	}
 
@@ -67,7 +67,7 @@ export class ViewletDescriptor extends CompositeDescriptor<Viewlet> {
 		super(ctor, id, name, cssClass, order, id);
 	}
 
-	get iconUrl(): URI {
+	get iconUrl(): URI | undefined {
 		return this._iconUrl;
 	}
 }
@@ -160,7 +160,7 @@ export class ShowViewletAction extends Action {
 		const activeViewlet = this.viewletService.getActiveViewlet();
 		const activeElement = document.activeElement;
 
-		return activeViewlet && activeElement && DOM.isAncestor(activeElement, this.partService.getContainer(Parts.SIDEBAR_PART));
+		return !!(activeViewlet && activeElement && DOM.isAncestor(activeElement, this.partService.getContainer(Parts.SIDEBAR_PART)));
 	}
 }
 

src/vs/workbench/common/viewlet.ts

@@ -10,5 +10,5 @@ export interface IViewlet extends IComposite {
 	/**
 	 * Returns the minimal width needed to avoid any content horizontal truncation
 	 */
-	getOptimalWidth(): number;
+	getOptimalWidth(): number | null;
 }