Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
b24f2849
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
b24f2849
编写于
4月 20, 2020
作者:
R
Rob Lourens
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix dragging cells down
上级
1dcfd02f
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
65 addition
and
1 deletion
+65
-1
src/vs/workbench/contrib/notebook/browser/viewModel/notebookViewModel.ts
...h/contrib/notebook/browser/viewModel/notebookViewModel.ts
+4
-1
src/vs/workbench/contrib/notebook/test/notebookViewModel.test.ts
...workbench/contrib/notebook/test/notebookViewModel.test.ts
+61
-0
未找到文件。
src/vs/workbench/contrib/notebook/browser/viewModel/notebookViewModel.ts
浏览文件 @
b24f2849
...
@@ -539,7 +539,10 @@ export class NotebookViewModel extends Disposable implements FoldingRegionDelega
...
@@ -539,7 +539,10 @@ export class NotebookViewModel extends Disposable implements FoldingRegionDelega
}
}
moveCellToIdx
(
index
:
number
,
newIdx
:
number
,
synchronous
:
boolean
,
pushedToUndoStack
:
boolean
=
true
):
boolean
{
moveCellToIdx
(
index
:
number
,
newIdx
:
number
,
synchronous
:
boolean
,
pushedToUndoStack
:
boolean
=
true
):
boolean
{
// TODO roblou - works differently if index > or < newIdx, fix, write tests
if
(
index
<
newIdx
)
{
// newIdx will be one less after index has been removed
newIdx
--
;
}
const
viewCell
=
this
.
viewCells
[
index
]
as
CellViewModel
;
const
viewCell
=
this
.
viewCells
[
index
]
as
CellViewModel
;
if
(
!
viewCell
)
{
if
(
!
viewCell
)
{
...
...
src/vs/workbench/contrib/notebook/test/notebookViewModel.test.ts
浏览文件 @
b24f2849
...
@@ -57,6 +57,67 @@ suite('NotebookViewModel', () => {
...
@@ -57,6 +57,67 @@ suite('NotebookViewModel', () => {
);
);
});
});
test
(
'
move cells down
'
,
function
()
{
withTestNotebook
(
instantiationService
,
blukEditService
,
undoRedoService
,
[
[[
'
//a
'
],
'
javascript
'
,
CellKind
.
Code
,
[],
{
editable
:
true
}],
[[
'
//b
'
],
'
javascript
'
,
CellKind
.
Code
,
[],
{
editable
:
true
}],
[[
'
//c
'
],
'
javascript
'
,
CellKind
.
Code
,
[],
{
editable
:
true
}],
],
(
editor
,
viewModel
)
=>
{
viewModel
.
moveCellToIdx
(
0
,
0
,
false
);
// no-op
assert
.
equal
(
viewModel
.
viewCells
[
0
].
getText
(),
'
//a
'
);
assert
.
equal
(
viewModel
.
viewCells
[
1
].
getText
(),
'
//b
'
);
viewModel
.
moveCellToIdx
(
0
,
1
,
false
);
// no-op (move to after this cell?)
assert
.
equal
(
viewModel
.
viewCells
[
0
].
getText
(),
'
//a
'
);
assert
.
equal
(
viewModel
.
viewCells
[
1
].
getText
(),
'
//b
'
);
viewModel
.
moveCellToIdx
(
0
,
2
,
false
);
// b, a, c
assert
.
equal
(
viewModel
.
viewCells
[
0
].
getText
(),
'
//b
'
);
assert
.
equal
(
viewModel
.
viewCells
[
1
].
getText
(),
'
//a
'
);
assert
.
equal
(
viewModel
.
viewCells
[
2
].
getText
(),
'
//c
'
);
viewModel
.
moveCellToIdx
(
0
,
3
,
false
);
// a, c, b
assert
.
equal
(
viewModel
.
viewCells
[
0
].
getText
(),
'
//a
'
);
assert
.
equal
(
viewModel
.
viewCells
[
1
].
getText
(),
'
//c
'
);
assert
.
equal
(
viewModel
.
viewCells
[
2
].
getText
(),
'
//b
'
);
}
);
});
test
(
'
move cells up
'
,
function
()
{
withTestNotebook
(
instantiationService
,
blukEditService
,
undoRedoService
,
[
[[
'
//a
'
],
'
javascript
'
,
CellKind
.
Code
,
[],
{
editable
:
true
}],
[[
'
//b
'
],
'
javascript
'
,
CellKind
.
Code
,
[],
{
editable
:
true
}],
[[
'
//c
'
],
'
javascript
'
,
CellKind
.
Code
,
[],
{
editable
:
true
}],
],
(
editor
,
viewModel
)
=>
{
viewModel
.
moveCellToIdx
(
1
,
0
,
false
);
// b, a, c
assert
.
equal
(
viewModel
.
viewCells
[
0
].
getText
(),
'
//b
'
);
assert
.
equal
(
viewModel
.
viewCells
[
1
].
getText
(),
'
//a
'
);
viewModel
.
moveCellToIdx
(
2
,
0
,
false
);
// c, b, a
assert
.
equal
(
viewModel
.
viewCells
[
0
].
getText
(),
'
//c
'
);
assert
.
equal
(
viewModel
.
viewCells
[
1
].
getText
(),
'
//b
'
);
assert
.
equal
(
viewModel
.
viewCells
[
2
].
getText
(),
'
//a
'
);
}
);
});
test
(
'
index
'
,
function
()
{
test
(
'
index
'
,
function
()
{
withTestNotebook
(
withTestNotebook
(
instantiationService
,
instantiationService
,
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录