提交 b15877de 编写于 作者: M Matt Bierner

Handle some edge cases of #18131

上级 807759ec
...@@ -638,25 +638,23 @@ class TypeScriptCompletionItemProvider implements vscode.CompletionItemProvider ...@@ -638,25 +638,23 @@ class TypeScriptCompletionItemProvider implements vscode.CompletionItemProvider
try { try {
const args: Proto.FileLocationRequestArgs = typeConverters.Position.toFileLocationRequestArgs(filepath, position); const args: Proto.FileLocationRequestArgs = typeConverters.Position.toFileLocationRequestArgs(filepath, position);
const response = await this.client.execute('quickinfo', args, token); const response = await this.client.execute('quickinfo', args, token);
if (response.type !== 'response' || !response.body) { if (response.type === 'response' && response.body) {
return true; switch (response.body.kind) {
} case 'var':
case 'let':
switch (response.body.kind) { case 'const':
case 'var': case 'alias':
case 'let': return false;
case 'const': }
case 'alias':
return false;
} }
} catch (e) { } catch {
return true; // Noop
} }
// Don't complete function call if there is already something that looks like a funciton call // Don't complete function call if there is already something that looks like a function call
// https://github.com/Microsoft/vscode/issues/18131 // https://github.com/Microsoft/vscode/issues/18131
const after = document.lineAt(position.line).text.slice(position.character); const after = document.lineAt(position.line).text.slice(position.character);
return after.match(/^\s*\(/g) === null; return after.match(/^[a-z_$0-9]*\s*\(/gi) === null;
} }
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册