提交 aa3b1fb3 编写于 作者: I isidor

viewsViewlet: openView is not async

上级 8f3f462c
...@@ -3,7 +3,6 @@ ...@@ -3,7 +3,6 @@
* Licensed under the MIT License. See License.txt in the project root for license information. * Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/ *--------------------------------------------------------------------------------------------*/
import { TPromise } from 'vs/base/common/winjs.base';
import * as DOM from 'vs/base/browser/dom'; import * as DOM from 'vs/base/browser/dom';
import { dispose, IDisposable, combinedDisposable, toDisposable } from 'vs/base/common/lifecycle'; import { dispose, IDisposable, combinedDisposable, toDisposable } from 'vs/base/common/lifecycle';
import { IAction } from 'vs/base/common/actions'; import { IAction } from 'vs/base/common/actions';
...@@ -194,7 +193,7 @@ export abstract class ViewContainerViewlet extends PanelViewlet implements IView ...@@ -194,7 +193,7 @@ export abstract class ViewContainerViewlet extends PanelViewlet implements IView
.map((view) => view.setVisible(visible)); .map((view) => view.setVisible(visible));
} }
openView(id: string, focus?: boolean): TPromise<IView> { openView(id: string, focus?: boolean): IView {
if (focus) { if (focus) {
this.focus(); this.focus();
} }
...@@ -207,7 +206,7 @@ export abstract class ViewContainerViewlet extends PanelViewlet implements IView ...@@ -207,7 +206,7 @@ export abstract class ViewContainerViewlet extends PanelViewlet implements IView
if (focus) { if (focus) {
view.focus(); view.focus();
} }
return Promise.resolve(view); return view;
} }
movePanel(from: ViewletPanel, to: ViewletPanel): void { movePanel(from: ViewletPanel, to: ViewletPanel): void {
......
...@@ -219,7 +219,7 @@ export interface IView { ...@@ -219,7 +219,7 @@ export interface IView {
export interface IViewsViewlet extends IViewlet { export interface IViewsViewlet extends IViewlet {
openView(id: string, focus?: boolean): TPromise<IView>; openView(id: string, focus?: boolean): IView;
} }
...@@ -344,4 +344,4 @@ export interface ITreeViewDataProvider { ...@@ -344,4 +344,4 @@ export interface ITreeViewDataProvider {
getChildren(element?: ITreeItem): TPromise<ITreeItem[]>; getChildren(element?: ITreeItem): TPromise<ITreeItem[]>;
} }
\ No newline at end of file
...@@ -1477,7 +1477,7 @@ export class SCMViewlet extends PanelViewlet implements IViewModel, IViewsViewle ...@@ -1477,7 +1477,7 @@ export class SCMViewlet extends PanelViewlet implements IViewModel, IViewsViewle
return super.isSingleView() && this.repositoryPanels.length + this.contributedViews.visibleViewDescriptors.length === 1; return super.isSingleView() && this.repositoryPanels.length + this.contributedViews.visibleViewDescriptors.length === 1;
} }
openView(id: string, focus?: boolean): TPromise<IView> { openView(id: string, focus?: boolean): IView {
if (focus) { if (focus) {
this.focus(); this.focus();
} }
...@@ -1490,7 +1490,7 @@ export class SCMViewlet extends PanelViewlet implements IViewModel, IViewsViewle ...@@ -1490,7 +1490,7 @@ export class SCMViewlet extends PanelViewlet implements IViewModel, IViewsViewle
if (focus) { if (focus) {
panel.focus(); panel.focus();
} }
return TPromise.as(panel); return panel;
} }
hide(repository: ISCMRepository): void { hide(repository: ISCMRepository): void {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册