Unbreak settings-related smoke tests

test/smoke/src/areas/css/css.test.ts

@@ -28,7 +28,7 @@ export function setup() {
 			await app.workbench.problems.hideProblemsView();
 		});
 
-		it.skip('verifies that warning becomes an error once setting changed', async function () {
+		it('verifies that warning becomes an error once setting changed', async function () {
 			// settings might take a while to update?
 			this.timeout(40000);
 

test/smoke/src/areas/preferences/preferences.test.ts

@@ -7,7 +7,7 @@ import { Application } from '../../application';
 import { ActivityBarPosition } from '../activitybar/activityBar';
 
 export function setup() {
-	describe.skip('Preferences', () => {
+	describe('Preferences', () => {
 		it('turns off editor line numbers and verifies the live change', async function () {
 			const app = this.app as Application;
 

test/smoke/src/areas/preferences/settings.ts

@@ -8,6 +8,7 @@ import * as path from 'path';
 import { Editor } from '../editor/editor';
 import { Editors } from '../editor/editors';
 import { Code } from '../../vscode/code';
+import { QuickOpen } from '../quickopen/quickopen';
 
 export enum ActivityBarPosition {
 	LEFT = 0,
@@ -18,7 +19,7 @@ const SEARCH_INPUT = '.settings-search-input input';
 
 export class SettingsEditor {
 
-	constructor(private code: Code, private userDataPath: string, private editors: Editors, private editor: Editor) { }
+	constructor(private code: Code, private userDataPath: string, private editors: Editors, private editor: Editor, private quickopen: QuickOpen) { }
 
 	async addUserSetting(setting: string, value: string): Promise<void> {
 		await this.openSettings();
@@ -41,10 +42,6 @@ export class SettingsEditor {
 	}
 
 	private async openSettings(): Promise<void> {
-		if (process.platform === 'darwin') {
-			await this.code.dispatchKeybinding('cmd+,');
-		} else {
-			await this.code.dispatchKeybinding('ctrl+,');
-		}
+		await this.quickopen.runCommand('Preferences: Open User Settings');
 	}
 }
\ No newline at end of file

test/smoke/src/areas/workbench/workbench.ts

@@ -55,7 +55,7 @@ export class Workbench {
 		this.debug = new Debug(code, this.quickopen, this.editors, this.editor);
 		this.statusbar = new StatusBar(code);
 		this.problems = new Problems(code);
-		this.settingsEditor = new SettingsEditor(code, userDataPath, this.editors, this.editor);
+		this.settingsEditor = new SettingsEditor(code, userDataPath, this.editors, this.editor, this.quickopen);
 		this.keybindingsEditor = new KeybindingsEditor(code);
 		this.terminal = new Terminal(code);
 	}