Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
a7122371
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
a7122371
编写于
7月 26, 2019
作者:
J
Johannes Rieken
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
dispo - add some more DisposableStore usage
上级
0911c90a
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
10 addition
and
11 deletion
+10
-11
src/vs/editor/contrib/suggest/suggestWidget.ts
src/vs/editor/contrib/suggest/suggestWidget.ts
+10
-11
未找到文件。
src/vs/editor/contrib/suggest/suggestWidget.ts
浏览文件 @
a7122371
...
...
@@ -50,7 +50,7 @@ interface ISuggestionTemplateData {
iconLabel
:
IconLabel
;
typeLabel
:
HTMLElement
;
readMore
:
HTMLElement
;
disposables
:
IDisposable
[]
;
disposables
:
DisposableStore
;
}
/**
...
...
@@ -106,8 +106,7 @@ class Renderer implements IListRenderer<CompletionItem, ISuggestionTemplateData>
renderTemplate
(
container
:
HTMLElement
):
ISuggestionTemplateData
{
const
data
=
<
ISuggestionTemplateData
>
Object
.
create
(
null
);
const
disposables
=
new
DisposableStore
();
data
.
disposables
=
[
disposables
];
data
.
disposables
=
new
DisposableStore
();
data
.
root
=
container
;
addClass
(
data
.
root
,
'
show-file-icons
'
);
...
...
@@ -119,7 +118,7 @@ class Renderer implements IListRenderer<CompletionItem, ISuggestionTemplateData>
const
main
=
append
(
text
,
$
(
'
.main
'
));
data
.
iconLabel
=
new
IconLabel
(
main
,
{
supportHighlights
:
true
});
disposables
.
add
(
data
.
iconLabel
);
d
ata
.
d
isposables
.
add
(
data
.
iconLabel
);
data
.
typeLabel
=
append
(
main
,
$
(
'
span.type-label
'
));
...
...
@@ -147,7 +146,7 @@ class Renderer implements IListRenderer<CompletionItem, ISuggestionTemplateData>
configureFont
();
disposables
.
add
(
Event
.
chain
<
IConfigurationChangedEvent
>
(
this
.
editor
.
onDidChangeConfiguration
.
bind
(
this
.
editor
))
d
ata
.
d
isposables
.
add
(
Event
.
chain
<
IConfigurationChangedEvent
>
(
this
.
editor
.
onDidChangeConfiguration
.
bind
(
this
.
editor
))
.
filter
(
e
=>
e
.
fontInfo
||
e
.
contribInfo
)
.
on
(
configureFont
,
null
));
...
...
@@ -218,7 +217,7 @@ class Renderer implements IListRenderer<CompletionItem, ISuggestionTemplateData>
}
disposeTemplate
(
templateData
:
ISuggestionTemplateData
):
void
{
templateData
.
disposables
=
dispose
(
templateData
.
disposables
);
templateData
.
disposables
.
dispose
(
);
}
}
...
...
@@ -253,7 +252,7 @@ class SuggestionDetails {
private
type
:
HTMLElement
;
private
docs
:
HTMLElement
;
private
ariaLabel
:
string
|
null
;
private
disposables
:
IDisposable
[]
;
private
readonly
disposables
:
DisposableStore
;
private
renderDisposeable
:
IDisposable
;
private
borderWidth
:
number
=
1
;
...
...
@@ -264,16 +263,16 @@ class SuggestionDetails {
private
readonly
markdownRenderer
:
MarkdownRenderer
,
private
readonly
triggerKeybindingLabel
:
string
,
)
{
this
.
disposables
=
[]
;
this
.
disposables
=
new
DisposableStore
()
;
this
.
el
=
append
(
container
,
$
(
'
.details
'
));
this
.
disposables
.
push
(
toDisposable
(()
=>
container
.
removeChild
(
this
.
el
)));
this
.
disposables
.
add
(
toDisposable
(()
=>
container
.
removeChild
(
this
.
el
)));
this
.
body
=
$
(
'
.body
'
);
this
.
scrollbar
=
new
DomScrollableElement
(
this
.
body
,
{});
append
(
this
.
el
,
this
.
scrollbar
.
getDomNode
());
this
.
disposables
.
push
(
this
.
scrollbar
);
this
.
disposables
.
add
(
this
.
scrollbar
);
this
.
header
=
append
(
this
.
body
,
$
(
'
.header
'
));
this
.
close
=
append
(
this
.
header
,
$
(
'
span.close
'
));
...
...
@@ -414,7 +413,7 @@ class SuggestionDetails {
}
dispose
():
void
{
this
.
disposables
=
dispose
(
this
.
disposables
);
this
.
disposables
.
dispose
(
);
this
.
renderDisposeable
=
dispose
(
this
.
renderDisposeable
);
}
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录