提交 9d1835d3 编写于 作者: R rebornix

#re #33344, revert the mouse move monitor checking as the bug is introduced by hue loss.

上级 ebd61ccd
...@@ -129,7 +129,6 @@ class SaturationBox extends Disposable { ...@@ -129,7 +129,6 @@ class SaturationBox extends Disposable {
private width: number; private width: number;
private height: number; private height: number;
private monitor: GlobalMouseMoveMonitor<IStandardMouseMoveEventData>;
private _onDidChange = new Emitter<{ s: number, v: number }>(); private _onDidChange = new Emitter<{ s: number, v: number }>();
readonly onDidChange: Event<{ s: number, v: number }> = this._onDidChange.event; readonly onDidChange: Event<{ s: number, v: number }> = this._onDidChange.event;
...@@ -155,24 +154,22 @@ class SaturationBox extends Disposable { ...@@ -155,24 +154,22 @@ class SaturationBox extends Disposable {
this._register(dom.addDisposableListener(this.domNode, dom.EventType.MOUSE_DOWN, e => this.onMouseDown(e))); this._register(dom.addDisposableListener(this.domNode, dom.EventType.MOUSE_DOWN, e => this.onMouseDown(e)));
this._register(this.model.onDidChangeColor(this.onDidChangeColor, this)); this._register(this.model.onDidChangeColor(this.onDidChangeColor, this));
this.monitor = null;
} }
private onMouseDown(e: MouseEvent): void { private onMouseDown(e: MouseEvent): void {
this.monitor = this._register(new GlobalMouseMoveMonitor<IStandardMouseMoveEventData>()); const monitor = this._register(new GlobalMouseMoveMonitor<IStandardMouseMoveEventData>());
const origin = dom.getDomNodePagePosition(this.domNode); const origin = dom.getDomNodePagePosition(this.domNode);
if (e.target !== this.selection) { if (e.target !== this.selection) {
this.onDidChangePosition(e.offsetX, e.offsetY); this.onDidChangePosition(e.offsetX, e.offsetY);
} }
this.monitor.startMonitoring(standardMouseMoveMerger, event => this.onDidChangePosition(event.posx - origin.left, event.posy - origin.top), () => null); monitor.startMonitoring(standardMouseMoveMerger, event => this.onDidChangePosition(event.posx - origin.left, event.posy - origin.top), () => null);
const mouseUpListener = dom.addDisposableListener(document, dom.EventType.MOUSE_UP, () => { const mouseUpListener = dom.addDisposableListener(document, dom.EventType.MOUSE_UP, () => {
this._onColorFlushed.fire(); this._onColorFlushed.fire();
mouseUpListener.dispose(); mouseUpListener.dispose();
this.monitor.stopMonitoring(true); monitor.stopMonitoring(true);
this.monitor = null;
}, true); }, true);
} }
...@@ -224,9 +221,6 @@ class SaturationBox extends Disposable { ...@@ -224,9 +221,6 @@ class SaturationBox extends Disposable {
} }
private onDidChangeColor(): void { private onDidChangeColor(): void {
if (this.monitor && this.monitor.isMonitoring()) {
return;
}
this.paint(); this.paint();
} }
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册