Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
9aa969cd
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
9aa969cd
编写于
10月 25, 2018
作者:
R
rebornix
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix #61546. Strict null checks for comment services.
上级
02275f04
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
8 addition
and
7 deletion
+8
-7
src/tsconfig.strictNullChecks.json
src/tsconfig.strictNullChecks.json
+1
-0
src/vs/workbench/parts/comments/electron-browser/commentService.ts
...rkbench/parts/comments/electron-browser/commentService.ts
+7
-7
未找到文件。
src/tsconfig.strictNullChecks.json
浏览文件 @
9aa969cd
...
...
@@ -503,6 +503,7 @@
"./vs/workbench/parts/codeEditor/electron-browser/toggleWordWrap.ts"
,
"./vs/workbench/parts/comments/common/commentModel.ts"
,
"./vs/workbench/parts/comments/electron-browser/commentGlyphWidget.ts"
,
"vs/workbench/parts/comments/electron-browser/commentService.ts"
,
"./vs/workbench/parts/emmet/browser/actions/showEmmetCommands.ts"
,
"./vs/workbench/parts/emmet/browser/emmet.browser.contribution.ts"
,
"./vs/workbench/parts/emmet/electron-browser/actions/expandAbbreviation.ts"
,
...
...
src/vs/workbench/parts/comments/electron-browser/commentService.ts
浏览文件 @
9aa969cd
...
...
@@ -37,8 +37,8 @@ export interface ICommentService {
registerDataProvider
(
owner
:
number
,
commentProvider
:
DocumentCommentProvider
):
void
;
unregisterDataProvider
(
owner
:
number
):
void
;
updateComments
(
event
:
CommentThreadChangedEvent
):
void
;
createNewCommentThread
(
owner
:
number
,
resource
:
URI
,
range
:
Range
,
text
:
string
):
Promise
<
CommentThread
>
;
replyToCommentThread
(
owner
:
number
,
resource
:
URI
,
range
:
Range
,
thread
:
CommentThread
,
text
:
string
):
Promise
<
CommentThread
>
;
createNewCommentThread
(
owner
:
number
,
resource
:
URI
,
range
:
Range
,
text
:
string
):
Promise
<
CommentThread
|
null
>
;
replyToCommentThread
(
owner
:
number
,
resource
:
URI
,
range
:
Range
,
thread
:
CommentThread
,
text
:
string
):
Promise
<
CommentThread
|
null
>
;
editComment
(
owner
:
number
,
resource
:
URI
,
comment
:
Comment
,
text
:
string
):
Promise
<
void
>
;
deleteComment
(
owner
:
number
,
resource
:
URI
,
comment
:
Comment
):
Promise
<
boolean
>
;
getComments
(
resource
:
URI
):
Promise
<
CommentInfo
[]
>
;
...
...
@@ -94,21 +94,21 @@ export class CommentService extends Disposable implements ICommentService {
this
.
_onDidUpdateCommentThreads
.
fire
(
event
);
}
createNewCommentThread
(
owner
:
number
,
resource
:
URI
,
range
:
Range
,
text
:
string
):
Promise
<
CommentThread
>
{
async
createNewCommentThread
(
owner
:
number
,
resource
:
URI
,
range
:
Range
,
text
:
string
):
Promise
<
CommentThread
|
null
>
{
const
commentProvider
=
this
.
_commentProviders
.
get
(
owner
);
if
(
commentProvider
)
{
return
commentProvider
.
createNewCommentThread
(
resource
,
range
,
text
,
CancellationToken
.
None
);
return
await
commentProvider
.
createNewCommentThread
(
resource
,
range
,
text
,
CancellationToken
.
None
);
}
return
null
;
}
replyToCommentThread
(
owner
:
number
,
resource
:
URI
,
range
:
Range
,
thread
:
CommentThread
,
text
:
string
):
Promise
<
CommentThread
>
{
async
replyToCommentThread
(
owner
:
number
,
resource
:
URI
,
range
:
Range
,
thread
:
CommentThread
,
text
:
string
):
Promise
<
CommentThread
|
null
>
{
const
commentProvider
=
this
.
_commentProviders
.
get
(
owner
);
if
(
commentProvider
)
{
return
commentProvider
.
replyToCommentThread
(
resource
,
range
,
thread
,
text
,
CancellationToken
.
None
);
return
await
commentProvider
.
replyToCommentThread
(
resource
,
range
,
thread
,
text
,
CancellationToken
.
None
);
}
return
null
;
...
...
@@ -121,7 +121,7 @@ export class CommentService extends Disposable implements ICommentService {
return
commentProvider
.
editComment
(
resource
,
comment
,
text
,
CancellationToken
.
None
);
}
return
null
;
return
Promise
.
resolve
(
void
0
)
;
}
deleteComment
(
owner
:
number
,
resource
:
URI
,
comment
:
Comment
):
Promise
<
boolean
>
{
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录