tweak setting, update defaut to only suggest outside of comments and strings, #9504

src/vs/editor/common/config/commonEditorConfig.ts

@@ -793,9 +793,9 @@ const editorConfiguration: IConfigurationNode = {
 							type: 'boolean',
 							description: nls.localize('wordBasedSuggestions.comments', "Enable word based suggestions inside comments.")
 						},
-						default: {
+						other: {
 							type: 'boolean',
-							description: nls.localize('wordBasedSuggestions.default', "Enable word based suggestions outside of strings and comments.")
+							description: nls.localize('wordBasedSuggestions.other', "Enable word based suggestions outside of strings and comments.")
 						},
 					}
 				}

src/vs/editor/common/config/defaultConfig.ts

@@ -98,7 +98,7 @@ class ConfigClass implements IConfiguration {
 			acceptSuggestionOnCommitCharacter: true,
 			snippetSuggestions: 'bottom',
 			emptySelectionClipboard: true,
-			wordBasedSuggestions: true,
+			wordBasedSuggestions: { other: true, strings: false, comments: false },
 			suggestFontSize: 0,
 			suggestLineHeight: 0,
 			selectionHighlight: true,

src/vs/editor/common/editorCommon.ts

@@ -482,7 +482,7 @@ export interface IEditorOptions {
 	/**
 	 * Enable word based suggestions. Defaults to 'true'
 	 */
-	wordBasedSuggestions?: boolean | { strings?: boolean, comments?: boolean, default?: boolean };
+	wordBasedSuggestions?: boolean | { strings?: boolean, comments?: boolean, other?: boolean };
 	/**
 	 * The font size for the suggest widget.
 	 * Defaults to the editor font size.

src/vs/editor/common/services/editorWorkerServiceImpl.ts

@@ -105,7 +105,7 @@ class WordBasedCompletionItemProvider implements modes.ISuggestSupport {
 			const { tokenType } = tokens.findTokenAtOffset(position.column - 1);
 			const shoudSuggestHere = (tokenType === modes.StandardTokenType.Comment && wordBasedSuggestions.comments)
 				|| (tokenType === modes.StandardTokenType.String && wordBasedSuggestions.strings)
-				|| (tokenType === modes.StandardTokenType.Other && wordBasedSuggestions.default);
+				|| (tokenType === modes.StandardTokenType.Other && wordBasedSuggestions.other);
 
 			if (shoudSuggestHere) {
 				return this._workerManager.withWorker().then(client => client.textualSuggest(model.uri, position));

src/vs/monaco.d.ts

@@ -1400,7 +1400,7 @@ declare module monaco.editor {
         wordBasedSuggestions?: boolean | {
             strings?: boolean;
             comments?: boolean;
-            default?: boolean;
+            other?: boolean;
         };
         /**
          * The font size for the suggest widget.