Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
96c3dbc1
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
96c3dbc1
编写于
4月 13, 2016
作者:
I
isidor
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
debug: better disposing of listeners
fixes #5091
上级
9261bc5d
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
16 addition
and
15 deletion
+16
-15
src/vs/workbench/parts/debug/electron-browser/debugService.ts
...vs/workbench/parts/debug/electron-browser/debugService.ts
+12
-15
src/vs/workbench/parts/debug/node/rawDebugSession.ts
src/vs/workbench/parts/debug/node/rawDebugSession.ts
+4
-0
未找到文件。
src/vs/workbench/parts/debug/electron-browser/debugService.ts
浏览文件 @
96c3dbc1
...
...
@@ -111,6 +111,7 @@ export class DebugService extends ee.EventEmitter implements debug.IDebugService
this
.
model
=
new
model
.
Model
(
this
.
loadBreakpoints
(),
this
.
storageService
.
getBoolean
(
DEBUG_BREAKPOINTS_ACTIVATED_KEY
,
StorageScope
.
WORKSPACE
,
true
),
this
.
loadFunctionBreakpoints
(),
this
.
loadExceptionBreakpoints
(),
this
.
loadWatchExpressions
());
this
.
toDispose
.
push
(
this
.
model
);
this
.
viewModel
=
new
viewmodel
.
ViewModel
();
this
.
registerListeners
(
eventService
,
lifecycleService
);
...
...
@@ -136,7 +137,7 @@ export class DebugService extends ee.EventEmitter implements debug.IDebugService
lifecycleService
.
onShutdown
(
this
.
store
,
this
);
lifecycleService
.
onShutdown
(
this
.
dispose
,
this
);
this
.
windowService
.
onBroadcast
(
this
.
onBroadcast
,
this
);
this
.
toDispose
.
push
(
this
.
windowService
.
onBroadcast
(
this
.
onBroadcast
,
this
)
);
}
private
onBroadcast
(
broadcast
:
IBroadcast
):
void
{
...
...
@@ -231,6 +232,7 @@ export class DebugService extends ee.EventEmitter implements debug.IDebugService
}
private
registerSessionListeners
():
void
{
this
.
toDisposeOnSessionEnd
.
push
(
this
.
session
);
this
.
toDisposeOnSessionEnd
.
push
(
this
.
session
.
addListener2
(
debug
.
SessionEvents
.
INITIALIZED
,
(
event
:
DebugProtocol
.
InitializedEvent
)
=>
{
aria
.
status
(
nls
.
localize
(
'
debuggingStarted
'
,
"
Debugging started.
"
));
this
.
sendAllBreakpoints
().
then
(()
=>
{
...
...
@@ -710,15 +712,8 @@ export class DebugService extends ee.EventEmitter implements debug.IDebugService
}
private
onSessionEnd
():
void
{
try
{
this
.
debugStringEditorInputs
=
lifecycle
.
dispose
(
this
.
debugStringEditorInputs
);
}
catch
(
e
)
{
// an internal module might be open so the dispose can throw -> ignore and continue with stop session.
}
if
(
this
.
session
)
{
const
bpsExist
=
this
.
model
.
getBreakpoints
().
length
>
0
;
this
.
session
.
dispose
();
this
.
telemetryService
.
publicLog
(
'
debugSessionStop
'
,
{
type
:
this
.
session
.
getType
(),
success
:
this
.
session
.
emittedStopped
||
!
bpsExist
,
...
...
@@ -729,7 +724,12 @@ export class DebugService extends ee.EventEmitter implements debug.IDebugService
}
this
.
session
=
null
;
this
.
toDisposeOnSessionEnd
=
lifecycle
.
dispose
(
this
.
toDisposeOnSessionEnd
);
try
{
this
.
toDisposeOnSessionEnd
=
lifecycle
.
dispose
(
this
.
toDisposeOnSessionEnd
);
}
catch
(
e
)
{
// an internal module might be open so the dispose can throw -> ignore and continue with stop session.
}
this
.
partService
.
removeClass
(
'
debugging
'
);
this
.
editorService
.
focusEditor
();
...
...
@@ -857,6 +857,8 @@ export class DebugService extends ee.EventEmitter implements debug.IDebugService
if
(
filtered
.
length
===
0
)
{
const
result
=
this
.
instantiationService
.
createInstance
(
DebugStringEditorInput
,
source
.
name
,
source
.
uri
,
source
.
origin
,
value
,
mtype
,
void
0
);
this
.
debugStringEditorInputs
.
push
(
result
);
this
.
toDisposeOnSessionEnd
.
push
(
result
);
return
result
;
}
else
{
return
filtered
[
0
];
...
...
@@ -933,12 +935,7 @@ export class DebugService extends ee.EventEmitter implements debug.IDebugService
}
public
dispose
():
void
{
if
(
this
.
session
)
{
this
.
session
.
disconnect
();
this
.
session
=
null
;
}
this
.
model
.
dispose
();
this
.
toDispose
=
lifecycle
.
dispose
(
this
.
toDispose
);
this
.
toDisposeOnSessionEnd
=
lifecycle
.
dispose
(
this
.
toDisposeOnSessionEnd
);
this
.
toDispose
=
lifecycle
.
dispose
(
this
.
toDispose
);
}
}
src/vs/workbench/parts/debug/node/rawDebugSession.ts
浏览文件 @
96c3dbc1
...
...
@@ -340,4 +340,8 @@ export class RawDebugSession extends v8.V8Protocol implements debug.IRawDebugSes
}
this
.
emit
(
debug
.
SessionEvents
.
SERVER_EXIT
);
}
public
dispose
():
void
{
this
.
disconnect
().
done
(
null
,
errors
.
onUnexpectedError
);
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录