Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
8d9356ea
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
8d9356ea
编写于
9月 30, 2019
作者:
M
Martin Aeschlimann
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Telemetry when exe recommendation is already installed
上级
c2997da2
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
36 addition
and
6 deletion
+36
-6
src/vs/workbench/contrib/extensions/browser/extensionTipsService.ts
...kbench/contrib/extensions/browser/extensionTipsService.ts
+36
-6
未找到文件。
src/vs/workbench/contrib/extensions/browser/extensionTipsService.ts
浏览文件 @
8d9356ea
...
...
@@ -513,9 +513,26 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
return
false
;
}
const
installed
=
await
this
.
extensionManagementService
.
getInstalled
(
ExtensionType
.
User
);
let
recommendationsToSuggest
=
Object
.
keys
(
this
.
_importantExeBasedRecommendations
);
recommendationsToSuggest
=
this
.
filterAllIgnoredInstalledAndNotAllowed
(
recommendationsToSuggest
,
installed
);
const
installed
=
await
this
.
extensionManagementService
.
getInstalled
(
ExtensionType
.
User
);
recommendationsToSuggest
=
this
.
filterInstalled
(
recommendationsToSuggest
,
installed
,
(
extensionId
)
=>
{
const
tip
=
this
.
_importantExeBasedRecommendations
[
extensionId
];
/* __GDPR__
exeExtensionRecommendations:alreadyInstalled" : {
"extensionId": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" },
"exeName": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }
}
*/
this
.
telemetryService
.
publicLog
(
'
exeExtensionRecommendations:alreadyInstalled
'
,
{
extensionId
,
exeName
:
tip
.
exeFriendlyName
||
basename
(
tip
.
windowsPath
!
)
});
});
if
(
recommendationsToSuggest
.
length
===
0
)
{
return
false
;
}
recommendationsToSuggest
=
this
.
filterIgnoredOrNotAllowed
(
recommendationsToSuggest
);
if
(
recommendationsToSuggest
.
length
===
0
)
{
return
false
;
}
...
...
@@ -747,7 +764,12 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
private
async
promptRecommendedExtensionForFileType
(
recommendationsToSuggest
:
string
[],
installed
:
ILocalExtension
[]):
Promise
<
boolean
>
{
recommendationsToSuggest
=
this
.
filterAllIgnoredInstalledAndNotAllowed
(
recommendationsToSuggest
,
installed
);
recommendationsToSuggest
=
this
.
filterIgnoredOrNotAllowed
(
recommendationsToSuggest
);
if
(
recommendationsToSuggest
.
length
===
0
)
{
return
false
;
}
recommendationsToSuggest
=
this
.
filterInstalled
(
recommendationsToSuggest
,
installed
);
if
(
recommendationsToSuggest
.
length
===
0
)
{
return
false
;
}
...
...
@@ -903,10 +925,8 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
);
}
private
filterAllIgnoredInstalledAndNotAllowed
(
recommendationsToSuggest
:
string
[],
installed
:
ILocalExtension
[]):
string
[]
{
private
filterIgnoredOrNotAllowed
(
recommendationsToSuggest
:
string
[]):
string
[]
{
const
importantRecommendationsIgnoreList
=
<
string
[]
>
JSON
.
parse
(
this
.
storageService
.
get
(
'
extensionsAssistant/importantRecommendationsIgnore
'
,
StorageScope
.
GLOBAL
,
'
[]
'
));
const
installedExtensionsIds
=
installed
.
reduce
((
result
,
i
)
=>
{
result
.
add
(
i
.
identifier
.
id
.
toLowerCase
());
return
result
;
},
new
Set
<
string
>
());
return
recommendationsToSuggest
.
filter
(
id
=>
{
if
(
importantRecommendationsIgnoreList
.
indexOf
(
id
)
!==
-
1
)
{
return
false
;
...
...
@@ -914,7 +934,17 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
if
(
!
this
.
isExtensionAllowedToBeRecommended
(
id
))
{
return
false
;
}
return
true
;
});
}
private
filterInstalled
(
recommendationsToSuggest
:
string
[],
installed
:
ILocalExtension
[],
onAlreadyInstalled
?:
(
id
:
string
)
=>
void
):
string
[]
{
const
installedExtensionsIds
=
installed
.
reduce
((
result
,
i
)
=>
{
result
.
add
(
i
.
identifier
.
id
.
toLowerCase
());
return
result
;
},
new
Set
<
string
>
());
return
recommendationsToSuggest
.
filter
(
id
=>
{
if
(
installedExtensionsIds
.
has
(
id
.
toLowerCase
()))
{
if
(
onAlreadyInstalled
)
{
onAlreadyInstalled
(
id
);
}
return
false
;
}
return
true
;
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录