debt - use progress service for progress notifications

src/vs/workbench/services/extensions/browser/extensionUrlHandler.ts

@@ -13,7 +13,7 @@ import { IExtensionGalleryService, IExtensionIdentifier, IExtensionManagementSer
 import { IWorkbenchExtensionEnablementService, EnablementState } from 'vs/workbench/services/extensionManagement/common/extensionManagement';
 import { areSameExtensions } from 'vs/platform/extensionManagement/common/extensionManagementUtil';
 import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
-import { INotificationHandle, INotificationService, Severity } from 'vs/platform/notification/common/notification';
+import { INotificationService, Severity } from 'vs/platform/notification/common/notification';
 import { IStorageService, StorageScope } from 'vs/platform/storage/common/storage';
 import { IURLHandler, IURLService, IOpenURLOptions } from 'vs/platform/url/common/url';
 import { IHostService } from 'vs/workbench/services/host/browser/host';
@@ -26,6 +26,7 @@ import { LifecyclePhase } from 'vs/platform/lifecycle/common/lifecycle';
 import { IWorkbenchActionRegistry, Extensions as WorkbenchActionExtensions } from 'vs/workbench/common/actions';
 import { SyncActionDescriptor } from 'vs/platform/actions/common/actions';
 import { IQuickInputService, IQuickPickItem } from 'vs/platform/quickinput/common/quickInput';
+import { IProgressService, ProgressLocation } from 'vs/platform/progress/common/progress';
 
 const FIVE_MINUTES = 5 * 60 * 1000;
 const THIRTY_SECONDS = 30 * 1000;
@@ -100,7 +101,8 @@ class ExtensionUrlHandler implements IExtensionUrlHandler, IURLHandler {
 		@IHostService private readonly hostService: IHostService,
 		@IExtensionGalleryService private readonly galleryService: IExtensionGalleryService,
 		@IStorageService private readonly storageService: IStorageService,
-		@IConfigurationService private readonly configurationService: IConfigurationService
+		@IConfigurationService private readonly configurationService: IConfigurationService,
+		@IProgressService private readonly progressService: IProgressService
 	) {
 		this.storage = new ConfirmedExtensionIdStorage(storageService);
 
@@ -273,32 +275,20 @@ class ExtensionUrlHandler implements IExtensionUrlHandler, IURLHandler {
 				return;
 			}
 
-			let notificationHandle: INotificationHandle | null = this.notificationService.notify({ severity: Severity.Info, message: localize('Installing', "Installing Extension '{0}'...", galleryExtension.displayName || galleryExtension.name) });
-			notificationHandle.progress.infinite();
-			notificationHandle.onDidClose(() => notificationHandle = null);
-
 			try {
-				await this.extensionManagementService.installFromGallery(galleryExtension);
-				const reloadMessage = localize('reload', "Would you like to reload the window and open the URL '{0}'?", uri.toString());
-				const reloadActionLabel = localize('Reload', "Reload Window and Open");
-
-				if (notificationHandle) {
-					notificationHandle.progress.done();
-					notificationHandle.updateMessage(reloadMessage);
-					notificationHandle.updateActions({
-						primary: [new Action('reloadWindow', reloadActionLabel, undefined, true, () => this.reloadAndHandle(uri))]
-					});
-				} else {
-					this.notificationService.prompt(Severity.Info, reloadMessage, [{ label: reloadActionLabel, run: () => this.reloadAndHandle(uri) }], { sticky: true });
-				}
-			} catch (e) {
-				if (notificationHandle) {
-					notificationHandle.progress.done();
-					notificationHandle.updateSeverity(Severity.Error);
-					notificationHandle.updateMessage(e);
-				} else {
-					this.notificationService.error(e);
-				}
+				await this.progressService.withProgress({
+					location: ProgressLocation.Notification,
+					title: localize('Installing', "Installing Extension '{0}'...", galleryExtension.displayName || galleryExtension.name)
+				}, () => this.extensionManagementService.installFromGallery(galleryExtension));
+
+				this.notificationService.prompt(
+					Severity.Info,
+					localize('reload', "Would you like to reload the window and open the URL '{0}'?", uri.toString()),
+					[{ label: localize('Reload', "Reload Window and Open"), run: () => this.reloadAndHandle(uri) }],
+					{ sticky: true }
+				);
+			} catch (error) {
+				this.notificationService.error(error);
 			}
 		}
 	}