editors - improve closeAll action to ignore save/revert result and rather check for dirty state

src/vs/workbench/browser/parts/editor/editorActions.ts

@@ -642,14 +642,13 @@ export abstract class BaseCloseAllAction extends Action {
 			return;
 		}
 
-		let saveOrRevert: boolean;
 		if (confirm === ConfirmResult.DONT_SAVE) {
-			saveOrRevert = await this.editorService.revertAll({ soft: true, includeUntitled: true });
+			await this.editorService.revertAll({ soft: true, includeUntitled: true });
 		} else {
-			saveOrRevert = await this.editorService.saveAll({ reason: SaveReason.EXPLICIT, includeUntitled: true });
+			await this.editorService.saveAll({ reason: SaveReason.EXPLICIT, includeUntitled: true });
 		}
 
-		if (saveOrRevert) {
+		if (!this.workingCopyService.hasDirty) {
 			return this.doCloseAll();
 		}
 	}

src/vs/workbench/services/editor/browser/editorService.ts

@@ -1034,10 +1034,6 @@ export class EditorService extends Disposable implements EditorServiceImpl {
 				return true; // might have been disposed from from the revert already
 			}
 
-			if (!editor.isDirty() && !options?.force) {
-				return true; // skip over non-dirty editors unless we force to revert
-			}
-
 			// Use revert as a hint to pin the editor
 			this.editorGroupService.getGroup(groupId)?.pinEditor(editor);