提交 82374457 编写于 作者: D Daniel Imms

Rename cols to columns

Fixes #52885
上级 2ed5aee8
...@@ -646,7 +646,7 @@ suite('window namespace tests', () => { ...@@ -646,7 +646,7 @@ suite('window namespace tests', () => {
}); });
const renderer = window.createTerminalRenderer('foo'); const renderer = window.createTerminalRenderer('foo');
const reg2 = renderer.onDidChangeMaximumDimensions(dimensions => { const reg2 = renderer.onDidChangeMaximumDimensions(dimensions => {
assert.ok(dimensions.cols > 0); assert.ok(dimensions.columns > 0);
assert.ok(dimensions.rows > 0); assert.ok(dimensions.rows > 0);
reg2.dispose(); reg2.dispose();
const reg3 = window.onDidCloseTerminal(() => { const reg3 = window.onDidCloseTerminal(() => {
......
...@@ -351,7 +351,7 @@ declare module 'vscode' { ...@@ -351,7 +351,7 @@ declare module 'vscode' {
/** /**
* The number of columns in the terminal. * The number of columns in the terminal.
*/ */
cols: number; columns: number;
/** /**
* The number of rows in the terminal. * The number of rows in the terminal.
......
...@@ -179,7 +179,7 @@ export class ExtHostTerminalRenderer extends BaseExtHostTerminal implements vsco ...@@ -179,7 +179,7 @@ export class ExtHostTerminalRenderer extends BaseExtHostTerminal implements vsco
} }
return { return {
rows: this._maximumDimensions.rows, rows: this._maximumDimensions.rows,
cols: this._maximumDimensions.cols columns: this._maximumDimensions.columns
}; };
} }
...@@ -212,8 +212,8 @@ export class ExtHostTerminalRenderer extends BaseExtHostTerminal implements vsco ...@@ -212,8 +212,8 @@ export class ExtHostTerminalRenderer extends BaseExtHostTerminal implements vsco
this._onInput.fire(data); this._onInput.fire(data);
} }
public _setMaximumDimensions(cols: number, rows: number): void { public _setMaximumDimensions(columns: number, rows: number): void {
this._maximumDimensions = { cols, rows }; this._maximumDimensions = { columns, rows };
this._onDidChangeMaximumDimensions.fire(this.maximumDimensions); this._onDidChangeMaximumDimensions.fire(this.maximumDimensions);
} }
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册