提交 7e317dca 编写于 作者: R Rob Lourens

Settings search - don't send extra settings values with feedback

上级 757ff83f
...@@ -684,7 +684,7 @@ export class FeedbackWidgetRenderer extends Disposable { ...@@ -684,7 +684,7 @@ export class FeedbackWidgetRenderer extends Disposable {
}).join('\n'); }).join('\n');
} }
private sendFeedback(feedbackEditor: ICodeEditor, result: IFilterResult, actualResults: IScoredResults): TPromise<void> { private sendFeedback(feedbackEditor: ICodeEditor, result: IFilterResult, scoredResults: IScoredResults): TPromise<void> {
const model = feedbackEditor.getModel(); const model = feedbackEditor.getModel();
const expectedQueryLines = model.getLinesContent() const expectedQueryLines = model.getLinesContent()
.filter(line => !strings.startsWith(line, '//')); .filter(line => !strings.startsWith(line, '//'));
...@@ -709,6 +709,13 @@ export class FeedbackWidgetRenderer extends Disposable { ...@@ -709,6 +709,13 @@ export class FeedbackWidgetRenderer extends Disposable {
const workbenchSettings = this.configurationService.getValue<IWorkbenchSettingsConfiguration>().workbench.settings; const workbenchSettings = this.configurationService.getValue<IWorkbenchSettingsConfiguration>().workbench.settings;
const autoIngest = workbenchSettings.naturalLanguageSearchAutoIngestFeedback; const autoIngest = workbenchSettings.naturalLanguageSearchAutoIngestFeedback;
const actualResultScores = {};
for (let key in scoredResults) {
actualResultScores[key] = {
score: scoredResults[key].score
};
}
/* __GDPR__ /* __GDPR__
"settingsSearchResultFeedback" : { "settingsSearchResultFeedback" : {
"query" : { "classification": "CustomContent", "purpose": "FeatureInsight" }, "query" : { "classification": "CustomContent", "purpose": "FeatureInsight" },
...@@ -721,7 +728,7 @@ export class FeedbackWidgetRenderer extends Disposable { ...@@ -721,7 +728,7 @@ export class FeedbackWidgetRenderer extends Disposable {
return this.telemetryService.publicLog('settingsSearchResultFeedback', { return this.telemetryService.publicLog('settingsSearchResultFeedback', {
query: result.query, query: result.query,
userComment, userComment,
actualResults, actualResults: actualResultScores,
expectedResults: expectedQuery.resultScores, expectedResults: expectedQuery.resultScores,
duration: result.metadata['nlpResult'].duration, duration: result.metadata['nlpResult'].duration,
buildNumber: this.environmentService.settingsSearchBuildId, buildNumber: this.environmentService.settingsSearchBuildId,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册