remove autoClosingPairs, surroundingPair in favour of deprecated api and...

remove autoClosingPairs, surroundingPair in favour of deprecated api and language config file, fixes #8737

extensions/css/client/src/cssMain.ts

@@ -59,13 +59,15 @@ export function activate(context: ExtensionContext) {
 			blockComment: ['/*', '*/']
 		},
 		brackets: [['{', '}'], ['[', ']'], ['(', ')']],
-		autoClosingPairs: [
-			{ open: '{', close: '}' },
-			{ open: '[', close: ']' },
-			{ open: '(', close: ')' },
-			{ open: '"', close: '"', notIn: ['string'] },
-			{ open: '\'', close: '\'', notIn: ['string'] }
-		]
+		__characterPairSupport: {
+			autoClosingPairs: [
+				{ open: '{', close: '}' },
+				{ open: '[', close: ']' },
+				{ open: '(', close: ')' },
+				{ open: '"', close: '"', notIn: ['string'] },
+				{ open: '\'', close: '\'', notIn: ['string'] }
+			]
+		}
 	});
 
 	languages.setLanguageConfiguration('less', {
@@ -75,14 +77,16 @@ export function activate(context: ExtensionContext) {
 			lineComment: '//'
 		},
 		brackets: [['{', '}'], ['[', ']'], ['(', ')'], ['<', '>']],
-		autoClosingPairs: [
-			{ open: '"', close: '"', notIn: ['string', 'comment'] },
-			{ open: '\'', close: '\'', notIn: ['string', 'comment'] },
-			{ open: '{', close: '}', notIn: ['string', 'comment'] },
-			{ open: '[', close: ']', notIn: ['string', 'comment'] },
-			{ open: '(', close: ')', notIn: ['string', 'comment'] },
-			{ open: '<', close: '>', notIn: ['string', 'comment'] },
-		]
+		__characterPairSupport: {
+			autoClosingPairs: [
+				{ open: '"', close: '"', notIn: ['string', 'comment'] },
+				{ open: '\'', close: '\'', notIn: ['string', 'comment'] },
+				{ open: '{', close: '}', notIn: ['string', 'comment'] },
+				{ open: '[', close: ']', notIn: ['string', 'comment'] },
+				{ open: '(', close: ')', notIn: ['string', 'comment'] },
+				{ open: '<', close: '>', notIn: ['string', 'comment'] },
+			]
+		}
 	});
 
 	languages.setLanguageConfiguration('scss', {
@@ -92,14 +96,16 @@ export function activate(context: ExtensionContext) {
 			lineComment: '//'
 		},
 		brackets: [['{', '}'], ['[', ']'], ['(', ')'], ['<', '>']],
-		autoClosingPairs: [
-			{ open: '"', close: '"', notIn: ['string', 'comment'] },
-			{ open: '\'', close: '\'', notIn: ['string', 'comment'] },
-			{ open: '{', close: '}', notIn: ['string', 'comment'] },
-			{ open: '[', close: ']', notIn: ['string', 'comment'] },
-			{ open: '(', close: ')', notIn: ['string', 'comment'] },
-			{ open: '<', close: '>', notIn: ['string', 'comment'] },
-		]
+		__characterPairSupport: {
+			autoClosingPairs: [
+				{ open: '"', close: '"', notIn: ['string', 'comment'] },
+				{ open: '\'', close: '\'', notIn: ['string', 'comment'] },
+				{ open: '{', close: '}', notIn: ['string', 'comment'] },
+				{ open: '[', close: ']', notIn: ['string', 'comment'] },
+				{ open: '(', close: ')', notIn: ['string', 'comment'] },
+				{ open: '<', close: '>', notIn: ['string', 'comment'] },
+			]
+		}
 	});
 
 	commands.registerCommand('_css.applyCodeAction', applyCodeAction);

extensions/json/client/src/jsonMain.ts

@@ -90,14 +90,16 @@ export function activate(context: ExtensionContext) {
 
 		languages.setLanguageConfiguration('json', {
 			wordPattern: /(-?\d*\.\d\w*)|([^\[\{\]\}\:\"\,\s]+)/g,
-			autoClosingPairs: [
-				{ open: '{', close: '}' },
-				{ open: '[', close: ']' },
-				{ open: '(', close: ')' },
-				{ open: '"', close: '"', notIn: ['string'] },
-				{ open: '\'', close: '\'', notIn: ['string', 'comment'] },
-				{ open: '`', close: '`', notIn: ['string', 'comment'] }
-			]
+			__characterPairSupport: {
+				autoClosingPairs: [
+					{ open: '{', close: '}' },
+					{ open: '[', close: ']' },
+					{ open: '(', close: ')' },
+					{ open: '"', close: '"', notIn: ['string'] },
+					{ open: '\'', close: '\'', notIn: ['string', 'comment'] },
+					{ open: '`', close: '`', notIn: ['string', 'comment'] }
+				]
+			}
 		});
 	});
 }

extensions/php/src/phpMain.ts

@@ -28,12 +28,14 @@ export function activate(context: ExtensionContext): any {
 	languages.setLanguageConfiguration('php', {
 		wordPattern: /(-?\d*\.\d\w*)|([^\-\`\~\!\@\#\%\^\&\*\(\)\=\+\[\{\]\}\\\|\;\:\'\"\,\.\<\>\/\?\s]+)/g,
 
-		autoClosingPairs: [
-			{ open: '{', close: '}' },
-			{ open: '[', close: ']' },
-			{ open: '(', close: ')' },
-			{ open: '"', close: '"', notIn: ['string'] },
-			{ open: '\'', close: '\'', notIn: ['string', 'comment'] }
-		]
+		__characterPairSupport: {
+			autoClosingPairs: [
+				{ open: '{', close: '}' },
+				{ open: '[', close: ']' },
+				{ open: '(', close: ')' },
+				{ open: '"', close: '"', notIn: ['string'] },
+				{ open: '\'', close: '\'', notIn: ['string', 'comment'] }
+			]
+		}
 	});
 }
\ No newline at end of file

extensions/typescript/src/typescriptMain.ts

@@ -210,14 +210,16 @@ class LanguageProvider {
 					docComment: { scope: 'comment.documentation', open: '/**', lineStart: ' * ', close: ' */' }
 				},
 
-				autoClosingPairs: [
-					{ open: '{', close: '}' },
-					{ open: '[', close: ']' },
-					{ open: '(', close: ')' },
-					{ open: '"', close: '"', notIn: ['string'] },
-					{ open: '\'', close: '\'', notIn: ['string', 'comment'] },
-					{ open: '`', close: '`', notIn: ['string', 'comment'] }
-				]
+				__characterPairSupport: {
+					autoClosingPairs: [
+						{ open: '{', close: '}' },
+						{ open: '[', close: ']' },
+						{ open: '(', close: ')' },
+						{ open: '"', close: '"', notIn: ['string'] },
+						{ open: '\'', close: '\'', notIn: ['string', 'comment'] },
+						{ open: '`', close: '`', notIn: ['string', 'comment'] }
+					]
+				}
 			});
 		});
 	}

src/vs/vscode.d.ts

@@ -2447,26 +2447,6 @@ declare namespace vscode {
 		 */
 		onEnterRules?: OnEnterRule[];
 
-		/**
-		 * The language's auto closing pairs. The 'close' character is automatically inserted with the
-		 * 'open' character is typed. If not set, the configured brackets will be used.
-		 */
-		autoClosingPairs?: {
-			open: string;
-			close: string;
-			notIn?: string[];
-		}[];
-
-		/**
-		 * The language's surrounding pairs. When the 'open' character is typed on a selection, the
-		 * selected string is surrounded by the open and close characters. If not set, the autoclosing pairs
-		 * settings will be used.
-		 */
-		surroundingPairs?: {
-			open: string;
-			close: string;
-		}[];
-
 		/**
 		 * **Deprecated** Do not use.
 		 *
@@ -2490,7 +2470,7 @@ declare namespace vscode {
 		/**
 		 * **Deprecated** Do not use.
 		 *
-		 * @deprecated Use autoClosingPairs and surroundingPairs instead.
+		 * @deprecated Use the language configuration file instead.
 		 */
 		__characterPairSupport?: {
 			autoClosingPairs: {

src/vs/workbench/api/node/extHostLanguageFeatures.ts

@@ -837,12 +837,6 @@ export class ExtHostLanguageFeatures {
 			this._documents.setWordDefinitionFor(languageId, null);
 		}
 
-		// backward compatibility, migrate deprecated setting
-		if (configuration.__characterPairSupport && !configuration.autoClosingPairs) {
-			configuration.autoClosingPairs = configuration.__characterPairSupport.autoClosingPairs;
-			delete configuration.__characterPairSupport;
-		}
-
 		const handle = this._nextHandle();
 		this._proxy.$setLanguageConfiguration(handle, languageId, configuration);
 		return this._createDisposable(handle);

src/vs/workbench/api/node/mainThreadLanguageFeatures.ts

@@ -16,7 +16,7 @@ import {CancellationToken} from 'vs/base/common/cancellation';
 import {Position as EditorPosition} from 'vs/editor/common/core/position';
 import {Range as EditorRange} from 'vs/editor/common/core/range';
 import {ExtHostContext, ExtHostLanguageFeaturesShape} from './extHostProtocol';
-import {LanguageConfigurationRegistry} from 'vs/editor/common/modes/languageConfigurationRegistry';
+import {LanguageConfigurationRegistry, LanguageConfiguration} from 'vs/editor/common/modes/languageConfigurationRegistry';
 
 export class MainThreadLanguageFeatures {
 
@@ -203,7 +203,12 @@ export class MainThreadLanguageFeatures {
 
 	// --- configuration
 
-	$setLanguageConfiguration(handle: number, languageId:string, configuration: vscode.LanguageConfiguration): TPromise<any> {
+	$setLanguageConfiguration(handle: number, languageId: string, configuration: vscode.LanguageConfiguration): TPromise<any> {
+
+		if (configuration.__characterPairSupport) {
+			(<LanguageConfiguration> configuration).autoClosingPairs = configuration.__characterPairSupport.autoClosingPairs;
+		}
+
 		this._registrations[handle] = LanguageConfigurationRegistry.register(languageId, configuration);
 		return undefined;
 	}