提交 7c53175e 编写于 作者: B Benjamin Pasero

web - add todo for potentially cyclic dependency

上级 88e76958
...@@ -412,6 +412,8 @@ export class SimpleWindowService extends Disposable implements IWindowService { ...@@ -412,6 +412,8 @@ export class SimpleWindowService extends Disposable implements IWindowService {
} }
closeWindow(): Promise<void> { closeWindow(): Promise<void> {
window.close();
return Promise.resolve(); return Promise.resolve();
} }
......
...@@ -17,7 +17,7 @@ class BrowserExtensionHostDebugService extends ExtensionHostDebugChannelClient { ...@@ -17,7 +17,7 @@ class BrowserExtensionHostDebugService extends ExtensionHostDebugChannelClient {
constructor( constructor(
@IRemoteAgentService remoteAgentService: IRemoteAgentService, @IRemoteAgentService remoteAgentService: IRemoteAgentService,
//@IWindowService windowService: IWindowService, // @IWindowService windowService: IWindowService, // TODO@weinand TODO@isidorn cyclic dependency?
@IEnvironmentService environmentService: IEnvironmentService @IEnvironmentService environmentService: IEnvironmentService
) { ) {
const connection = remoteAgentService.getConnection(); const connection = remoteAgentService.getConnection();
...@@ -30,13 +30,11 @@ class BrowserExtensionHostDebugService extends ExtensionHostDebugChannelClient { ...@@ -30,13 +30,11 @@ class BrowserExtensionHostDebugService extends ExtensionHostDebugChannelClient {
this._register(this.onReload(event => { this._register(this.onReload(event => {
if (environmentService.isExtensionDevelopment && environmentService.debugExtensionHost.debugId === event.sessionId) { if (environmentService.isExtensionDevelopment && environmentService.debugExtensionHost.debugId === event.sessionId) {
//windowService.reloadWindow();
window.location.reload(); window.location.reload();
} }
})); }));
this._register(this.onClose(event => { this._register(this.onClose(event => {
if (environmentService.isExtensionDevelopment && environmentService.debugExtensionHost.debugId === event.sessionId) { if (environmentService.isExtensionDevelopment && environmentService.debugExtensionHost.debugId === event.sessionId) {
//this._windowService.closeWindow();
window.close(); window.close();
} }
})); }));
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册