Revert "Use a config interface for terminal creation in API"

We're sticking with simple for now, an overload can be used if a config object
is necessary later.

This reverts commit 873b3d0b.

src/vs/vscode.d.ts

@@ -3029,16 +3029,6 @@ declare namespace vscode {
 		dispose(): void;
 	}
 
-	/**
-	 * A configuration describing a terminal within the integrated terminal.
-	 */
-	export interface TerminalConfiguration {
-		/**
-		 * A human-readable string which will be used to represent the terminal in the UI.
-		 */
-		name?: string
-	}
-
 	/**
 	 * Represents an extension.
 	 *
@@ -3501,10 +3491,10 @@ declare namespace vscode {
 		/**
 		 * Creates a [Terminal](#Terminal).
 		 *
-		 * @param configuration A configuration object for the terminal.
+		 * @param name Optional human-readable string which will be used to represent the terminal in the UI.
 		 * @return A new Terminal.
 		 */
-		export function createTerminal(configuration: TerminalConfiguration): Terminal;
+		export function createTerminal(name?: string): Terminal;
 	}
 
 	/**

src/vs/workbench/api/node/extHost.api.impl.ts

@@ -258,8 +258,8 @@ export class ExtHostAPIImplementation {
 			createOutputChannel(name: string): vscode.OutputChannel {
 				return extHostOutputService.createOutputChannel(name);
 			},
-			createTerminal(configuration: vscode.TerminalConfiguration): vscode.Terminal {
-				return extHostTerminalService.createTerminal(configuration);
+			createTerminal(name?: string): vscode.Terminal {
+				return extHostTerminalService.createTerminal(name);
 			}
 		};
 

src/vs/workbench/api/node/extHostTerminalService.ts

@@ -85,8 +85,8 @@ export class ExtHostTerminalService {
 		this._proxy = threadService.get(MainContext.MainThreadTerminalService);
 	}
 
-	public createTerminal(configuration: vscode.TerminalConfiguration): vscode.Terminal {
-		return new ExtHostTerminal(this._proxy, -1, configuration.name);
+	public createTerminal(name?: string): vscode.Terminal {
+		return new ExtHostTerminal(this._proxy, -1, name);
 	}
 }