Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
7756abff
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
7756abff
编写于
8月 23, 2018
作者:
C
Christopher Leidigh
提交者:
GitHub
8月 23, 2018
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Settings: Allow description to toggle checkbox Fixes: #54053 (#57103)
上级
f0e2534a
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
21 addition
and
2 deletion
+21
-2
src/vs/workbench/parts/preferences/browser/settingsTree.ts
src/vs/workbench/parts/preferences/browser/settingsTree.ts
+21
-2
未找到文件。
src/vs/workbench/parts/preferences/browser/settingsTree.ts
浏览文件 @
7756abff
...
...
@@ -673,6 +673,21 @@ export class SettingsRenderer implements ITreeRenderer {
template
.
onChange
(
checkbox
.
checked
);
}
}));
// Need to listen for mouse clicks on description and toggle checkbox - use target ID for safety
// Also have to ignore embedded links - too buried to stop propagation
toDispose
.
push
(
DOM
.
addDisposableListener
(
descriptionElement
,
DOM
.
EventType
.
MOUSE_DOWN
,
(
e
)
=>
{
const
targetElement
=
<
HTMLElement
>
e
.
toElement
;
const
targetId
=
descriptionElement
.
getAttribute
(
'
checkboxLabelTargetId
'
);
// Make sure we are not a link and the target ID matches
// Toggle target checkbox
if
(
targetElement
.
tagName
!==
'
A
'
&&
targetId
===
template
.
checkbox
.
domNode
.
id
)
{
template
.
checkbox
.
checked
=
template
.
checkbox
.
checked
?
false
:
true
;
}
DOM
.
EventHelper
.
stop
(
e
);
}));
checkbox
.
domNode
.
classList
.
add
(
SettingsRenderer
.
CONTROL_CLASS
);
const
toolbar
=
this
.
renderSettingToolbar
(
container
);
toDispose
.
push
(
toolbar
);
...
...
@@ -917,6 +932,10 @@ export class SettingsRenderer implements ITreeRenderer {
template
.
descriptionElement
.
innerText
=
element
.
description
;
}
// Add checkbox target to description clickable and able to toggle checkbox
const
checkbox_id
=
(
element
.
displayCategory
+
'
_
'
+
element
.
displayLabel
).
replace
(
/ /g
,
'
_
'
)
+
'
_Item
'
;
template
.
descriptionElement
.
setAttribute
(
'
checkboxLabelTargetId
'
,
checkbox_id
);
if
(
element
.
overriddenScopeList
.
length
)
{
let
otherOverridesLabel
=
element
.
isConfigured
?
localize
(
'
alsoConfiguredIn
'
,
"
Also modified in
"
)
:
...
...
@@ -988,9 +1007,9 @@ export class SettingsRenderer implements ITreeRenderer {
// Labels will not be read on descendent input elements of the parent treeitem
// unless defined as role=treeitem and indirect aria-labelledby approach
// TODO: Determine method to normally label input items with value read last
template
.
checkbox
.
domNode
.
setAttribute
(
'
id
'
,
id
+
'
i
tem
'
);
template
.
checkbox
.
domNode
.
setAttribute
(
'
id
'
,
id
+
'
_I
tem
'
);
template
.
checkbox
.
domNode
.
setAttribute
(
'
role
'
,
'
treeitem
'
);
template
.
checkbox
.
domNode
.
setAttribute
(
'
aria-labelledby
'
,
id
+
'
i
tem
'
+
id
);
template
.
checkbox
.
domNode
.
setAttribute
(
'
aria-labelledby
'
,
id
+
'
_I
tem
'
+
id
);
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录