Never return undefined for cachedResponse.execute

extensions/typescript-language-features/src/features/baseCodeLensProvider.ts

@@ -54,7 +54,7 @@ export abstract class TypeScriptBaseCodeLensProvider implements vscode.CodeLensP
 		}
 
 		const response = await this.cachedResponse.execute(document, () => this.client.execute('navtree', { file: filepath }, token));
-		if (!response || response.type !== 'response') {
+		if (response.type !== 'response') {
 			return [];
 		}
 

extensions/typescript-language-features/src/features/documentSymbol.ts

@@ -43,7 +43,7 @@ class TypeScriptDocumentSymbolProvider implements vscode.DocumentSymbolProvider
 
 		const args: Proto.FileRequestArgs = { file };
 		const response = await this.cachedResponse.execute(resource, () => this.client.execute('navtree', args, token));
-		if (!response || response.type !== 'response' || !response.body) {
+		if (response.type !== 'response' || !response.body) {
 			return undefined;
 		}
 

extensions/typescript-language-features/src/tsServer/cachedResponse.ts

@@ -12,8 +12,11 @@ export class CachedResponse<T extends Proto.Response> {
 	private version: number = -1;
 	private document: string = '';
 
-	public execute(document: vscode.TextDocument, f: () => Promise<ServerResponse<T>>) {
-		if (this.matches(document)) {
+	public execute(
+		document: vscode.TextDocument,
+		f: () => Promise<ServerResponse<T>>
+	): Promise<ServerResponse<T>> {
+		if (this.response && this.matches(document)) {
 			return this.response;
 		}
 		return this.update(document, f());