Move `Open Webview Developer tools` to electron contribution point

I don't think we can programatically open dev tools on the web

src/vs/workbench/contrib/webview/browser/webview.contribution.ts

@@ -17,8 +17,8 @@ import { EditorDescriptor, Extensions as EditorExtensions, IEditorRegistry } fro
 import { Extensions as ActionExtensions, IWorkbenchActionRegistry } from 'vs/workbench/common/actions';
 import { Extensions as EditorInputExtensions, IEditorInputFactoryRegistry } from 'vs/workbench/common/editor';
 import { WebviewEditorInputFactory } from 'vs/workbench/contrib/webview/browser/webviewEditorInputFactory';
-import { KEYBINDING_CONTEXT_WEBVIEW_FIND_WIDGET_VISIBLE } from 'vs/workbench/contrib/webview/common/webview';
-import { CopyWebviewEditorCommand, CutWebviewEditorCommand, HideWebViewEditorFindCommand, OpenWebviewDeveloperToolsAction, PasteWebviewEditorCommand, RedoWebviewEditorCommand, ReloadWebviewAction, SelectAllWebviewEditorCommand, ShowWebViewEditorFindWidgetCommand, UndoWebviewEditorCommand } from '../browser/webviewCommands';
+import { KEYBINDING_CONTEXT_WEBVIEW_FIND_WIDGET_VISIBLE, webviewDeveloperCategory } from 'vs/workbench/contrib/webview/common/webview';
+import { CopyWebviewEditorCommand, CutWebviewEditorCommand, HideWebViewEditorFindCommand, PasteWebviewEditorCommand, RedoWebviewEditorCommand, ReloadWebviewAction, SelectAllWebviewEditorCommand, ShowWebViewEditorFindWidgetCommand, UndoWebviewEditorCommand } from '../browser/webviewCommands';
 import { WebviewEditor } from '../browser/webviewEditor';
 import { WebviewEditorInput } from '../browser/webviewEditorInput';
 import { IWebviewEditorService, WebviewEditorService } from '../browser/webviewEditorService';
@@ -35,9 +35,6 @@ Registry.as<IEditorInputFactoryRegistry>(EditorInputExtensions.EditorInputFactor
 
 registerSingleton(IWebviewEditorService, WebviewEditorService, true);
 
-
-const webviewDeveloperCategory = localize('developer', "Developer");
-
 const actionRegistry = Registry.as<IWorkbenchActionRegistry>(ActionExtensions.WorkbenchActions);
 
 export function registerWebViewCommands(editorId: string): void {
@@ -127,11 +124,6 @@ export function registerWebViewCommands(editorId: string): void {
 
 registerWebViewCommands(WebviewEditor.ID);
 
-actionRegistry.registerWorkbenchAction(
-	new SyncActionDescriptor(OpenWebviewDeveloperToolsAction, OpenWebviewDeveloperToolsAction.ID, OpenWebviewDeveloperToolsAction.LABEL),
-	'Open Webview Developer Tools',
-	webviewDeveloperCategory);
-
 actionRegistry.registerWorkbenchAction(
 	new SyncActionDescriptor(ReloadWebviewAction, ReloadWebviewAction.ID, ReloadWebviewAction.LABEL),
 	'Reload Webviews',

src/vs/workbench/contrib/webview/browser/webviewCommands.ts

@@ -98,30 +98,6 @@ export class RedoWebviewEditorCommand extends Command {
 	}
 }
 
-export class OpenWebviewDeveloperToolsAction extends Action {
-	static readonly ID = 'workbench.action.webview.openDeveloperTools';
-	static readonly LABEL = nls.localize('openToolsLabel', "Open Webview Developer Tools");
-
-	public constructor(
-		id: string,
-		label: string
-	) {
-		super(id, label);
-	}
-
-	public run(): Promise<any> {
-		const elements = document.querySelectorAll('webview.ready');
-		for (let i = 0; i < elements.length; i++) {
-			try {
-				(elements.item(i) as Electron.WebviewTag).openDevTools();
-			} catch (e) {
-				console.error(e);
-			}
-		}
-		return Promise.resolve(true);
-	}
-}
-
 export class ReloadWebviewAction extends Action {
 	static readonly ID = 'workbench.action.webview.reloadWebviewAction';
 	static readonly LABEL = nls.localize('refreshWebviewLabel', "Reload Webviews");

src/vs/workbench/contrib/webview/common/webview.ts

@@ -10,6 +10,7 @@ import * as modes from 'vs/editor/common/modes';
 import { RawContextKey } from 'vs/platform/contextkey/common/contextkey';
 import { ExtensionIdentifier } from 'vs/platform/extensions/common/extensions';
 import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
+import * as nls from 'vs/nls';
 
 /**
  * Set when the find widget in a webview is visible.
@@ -83,3 +84,5 @@ export interface Webview extends IDisposable {
 	showFind(): void;
 	hideFind(): void;
 }
+
+export const webviewDeveloperCategory = nls.localize('developer', "Developer");

src/vs/workbench/contrib/webview/electron-browser/pre/webviewCommands.ts

+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import { Action } from 'vs/base/common/actions';
+import * as nls from 'vs/nls';
+import { SyncActionDescriptor } from 'vs/platform/actions/common/actions';
+import { Registry } from 'vs/platform/registry/common/platform';
+import { Extensions as ActionExtensions, IWorkbenchActionRegistry } from 'vs/workbench/common/actions';
+import { webviewDeveloperCategory } from 'vs/workbench/contrib/webview/common/webview';
+
+export class OpenWebviewDeveloperToolsAction extends Action {
+	static readonly ID = 'workbench.action.webview.openDeveloperTools';
+	static readonly LABEL = nls.localize('openToolsLabel', "Open Webview Developer Tools");
+
+	public constructor(id: string, label: string) {
+		super(id, label);
+	}
+
+	public run(): Promise<any> {
+		const elements = document.querySelectorAll('webview.ready');
+		for (let i = 0; i < elements.length; i++) {
+			try {
+				(elements.item(i) as Electron.WebviewTag).openDevTools();
+			} catch (e) {
+				console.error(e);
+			}
+		}
+		return Promise.resolve(true);
+	}
+}
+
+const actionRegistry = Registry.as<IWorkbenchActionRegistry>(ActionExtensions.WorkbenchActions);
+
+actionRegistry.registerWorkbenchAction(
+	new SyncActionDescriptor(OpenWebviewDeveloperToolsAction, OpenWebviewDeveloperToolsAction.ID, OpenWebviewDeveloperToolsAction.LABEL),
+	'Open Webview Developer Tools',
+	webviewDeveloperCategory);