Emmet: canceling wrap shouldn't add tab to the active editor (#8489)

* fix #8450

* Fix this problem for Update Tag command

* Return the tab key only for Expand Abbreviation command

src/vs/workbench/parts/emmet/node/actions/updateTag.ts

@@ -34,7 +34,7 @@ class UpdateTagAction extends EmmetEditorAction {
 	}
 
 	private wrapAbbreviation(_emmet: any, tag) {
-		if (!_emmet.run('update_tag', this.editorAccessor, tag)) {
+		if (tag && !_emmet.run('update_tag', this.editorAccessor, tag)) {
 			this.editorAccessor.noExpansionOccurred();
 		}
 	}

src/vs/workbench/parts/emmet/node/actions/wrapWithAbbreviation.ts

@@ -34,7 +34,7 @@ class WrapWithAbbreviationAction extends EmmetEditorAction {
 	}
 
 	private wrapAbbreviation(_emmet: any, abbreviation) {
-		if (!_emmet.run('wrap_with_abbreviation', this.editorAccessor, abbreviation)) {
+		if (abbreviation && !_emmet.run('wrap_with_abbreviation', this.editorAccessor, abbreviation)) {
 			this.editorAccessor.noExpansionOccurred();
 		}
 	}

src/vs/workbench/parts/emmet/node/editorAccessor.ts

@@ -23,9 +23,11 @@ export class EditorAccessor implements emmet.Editor {
 		this.editor = editor;
 	}
 
-	public noExpansionOccurred(): void {
-		// return the tab key handling back to the editor
-		this.editor.trigger('emmet', Handler.Tab, {});
+	public noExpansionOccurred(actionId?: string): void {
+		// return the tab key handling back to the editor only for Expand Abbreviation command
+		if (actionId === 'editor.emmet.action.expandAbbreviation') {
+			this.editor.trigger('emmet', Handler.Tab, {});
+		}
 	}
 
 	public isEmmetEnabledMode(): boolean {

src/vs/workbench/parts/emmet/node/emmetActions.ts

@@ -68,7 +68,7 @@ export abstract class EmmetEditorAction extends EditorAction {
 
 				try {
 					if (!this.editorAccessor.isEmmetEnabledMode()) {
-						this.editorAccessor.noExpansionOccurred();
+						this.editorAccessor.noExpansionOccurred(this.id);
 						return;
 					}
 					this.updateEmmetPreferences(_emmet);