Compile build in strict mode

build/lib/i18n.js

@@ -1054,7 +1054,6 @@ function prepareI18nPackFiles(externalExtensions, resultingTranslationPaths, pse
     var mainPack = { version: i18nPackVersion, contents: {} };
     var extensionsPacks = {};
     return event_stream_1.through(function (xlf) {
-        var stream = this;
         var project = path.dirname(xlf.path);
         var resource = path.basename(xlf.path, '.xlf');
         var contents = xlf.contents.toString();

build/lib/i18n.ts

@@ -1182,7 +1182,6 @@ export function prepareI18nPackFiles(externalExtensions: Map<string>, resultingT
 	let mainPack: I18nPack = { version: i18nPackVersion, contents: {} };
 	let extensionsPacks: Map<I18nPack> = {};
 	return through(function (this: ThroughStream, xlf: File) {
-		let stream = this;
 		let project = path.dirname(xlf.path);
 		let resource = path.basename(xlf.path, '.xlf');
 		let contents = xlf.contents.toString();

build/lib/standalone.ts

@@ -47,7 +47,7 @@ export function extractEditor(options: tss.ITreeShakingOptions & { destRoot: str
 		const dstPath = path.join(options.destRoot, fileName);
 		writeFile(dstPath, fs.readFileSync(srcPath));
 	};
-	const writeOutputFile = (fileName: string, contents: string) => {
+	const writeOutputFile = (fileName: string, contents: string | Buffer) => {
 		writeFile(path.join(options.destRoot, fileName), contents);
 	};
 	for (let fileName in result) {

build/monaco/api.js

@@ -447,7 +447,6 @@ function execute() {
     var languageService = ts.createLanguageService(new TypeScriptLanguageServiceHost({}, SRC_FILES, {}));
     var t1 = Date.now();
     Object.keys(SRC_FILES).forEach(function (fileName) {
-        var t = Date.now();
         var emitOutput = languageService.getEmitOutput(fileName, true);
         OUTPUT_FILES[SRC_FILE_TO_EXPECTED_NAME[fileName]] = emitOutput.outputFiles[0].text;
         // console.log(`Generating .d.ts for ${fileName} took ${Date.now() - t} ms`);

build/monaco/api.ts

@@ -534,7 +534,6 @@ export function execute(): IMonacoDeclarationResult {
 
 	var t1 = Date.now();
 	Object.keys(SRC_FILES).forEach((fileName) => {
-		var t = Date.now();
 		const emitOutput = languageService.getEmitOutput(fileName, true);
 		OUTPUT_FILES[SRC_FILE_TO_EXPECTED_NAME[fileName]] = emitOutput.outputFiles[0].text;
 		// console.log(`Generating .d.ts for ${fileName} took ${Date.now() - t} ms`);

build/tfs/darwin/enqueue.js

@@ -40,7 +40,6 @@ var __generator = (this && this.__generator) || function (thisArg, body) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 var child_process_1 = require("child_process");
-var documentdb_1 = require("documentdb");
 var azure = require("azure-storage");
 function queueSigningRequest(quality, commit) {
     var retryOperations = new azure.ExponentialRetryPolicyFilter();
@@ -51,39 +50,6 @@ function queueSigningRequest(quality, commit) {
     var message = quality + "/" + commit;
     return new Promise(function (c, e) { return queueSvc.createMessage('sign-darwin', message, function (err) { return err ? e(err) : c(); }); });
 }
-function isBuildSigned(quality, commit) {
-    var client = new documentdb_1.DocumentClient(process.env['AZURE_DOCUMENTDB_ENDPOINT'], { masterKey: process.env['AZURE_DOCUMENTDB_MASTERKEY'] });
-    var collection = 'dbs/builds/colls/' + quality;
-    var updateQuery = {
-        query: 'SELECT TOP 1 * FROM c WHERE c.id = @id',
-        parameters: [{ name: '@id', value: commit }]
-    };
-    return new Promise(function (c, e) {
-        client.queryDocuments(collection, updateQuery).toArray(function (err, results) {
-            if (err) {
-                return e(err);
-            }
-            if (results.length !== 1) {
-                return c(false);
-            }
-            var release = results[0];
-            var assets = release.assets;
-            var isSigned = assets.some(function (a) { return a.platform === 'darwin' && a.type === 'archive'; });
-            c(isSigned);
-        });
-    });
-}
-// async function waitForSignedBuild(quality: string, commit: string): Promise<void> {
-// 	let retries = 0;
-// 	while (retries < 180) {
-// 		if (await isBuildSigned(quality, commit)) {
-// 			return;
-// 		}
-// 		await new Promise<void>(c => setTimeout(c, 10000));
-// 		retries++;
-// 	}
-// 	throw new Error('Timed out waiting for signed build');
-// }
 function main(quality) {
     return __awaiter(this, void 0, void 0, function () {
         var commit;

build/tfs/darwin/enqueue.ts

@@ -6,16 +6,8 @@
 'use strict';
 
 import { execSync } from 'child_process';
-import { DocumentClient } from 'documentdb';
 import * as azure from 'azure-storage';
 
-interface Asset {
-	platform: string;
-	type: string;
-	url: string;
-	mooncakeUrl: string;
-	hash: string;
-}
 
 function queueSigningRequest(quality: string, commit: string): Promise<void> {
 	const retryOperations = new azure.ExponentialRetryPolicyFilter();
@@ -30,42 +22,6 @@ function queueSigningRequest(quality: string, commit: string): Promise<void> {
 	return new Promise<void>((c, e) => queueSvc.createMessage('sign-darwin', message, err => err ? e(err) : c()));
 }
 
-function isBuildSigned(quality: string, commit: string): Promise<boolean> {
-	const client = new DocumentClient(process.env['AZURE_DOCUMENTDB_ENDPOINT']!, { masterKey: process.env['AZURE_DOCUMENTDB_MASTERKEY'] });
-	const collection = 'dbs/builds/colls/' + quality;
-	const updateQuery = {
-		query: 'SELECT TOP 1 * FROM c WHERE c.id = @id',
-		parameters: [{ name: '@id', value: commit }]
-	};
-
-	return new Promise<boolean>((c, e) => {
-		client.queryDocuments(collection, updateQuery).toArray((err, results) => {
-			if (err) { return e(err); }
-			if (results.length !== 1) { return c(false); }
-
-			const [release] = results;
-			const assets: Asset[] = release.assets;
-			const isSigned = assets.some(a => a.platform === 'darwin' && a.type === 'archive');
-
-			c(isSigned);
-		});
-	});
-}
-
-// async function waitForSignedBuild(quality: string, commit: string): Promise<void> {
-// 	let retries = 0;
-
-// 	while (retries < 180) {
-// 		if (await isBuildSigned(quality, commit)) {
-// 			return;
-// 		}
-
-// 		await new Promise<void>(c => setTimeout(c, 10000));
-// 		retries++;
-// 	}
-
-// 	throw new Error('Timed out waiting for signed build');
-// }
 
 async function main(quality: string): Promise<void> {
 	const commit = execSync('git rev-parse HEAD', { encoding: 'utf8' }).trim();

build/tsconfig.json

@@ -2,7 +2,6 @@
 	"compilerOptions": {
 		"target": "es5",
 		"module": "commonjs",
-		"noImplicitAny": true,
 		"removeComments": false,
 		"preserveConstEnums": true,
 		"sourceMap": false,
@@ -13,7 +12,8 @@
 		// type checking so that JavaScript file are not transpiled
 		"allowJs": true,
 		"checkJs": true,
-		"strictNullChecks": true
+		"strict": true,
+		"noUnusedLocals": true
 	},
 	"exclude": [
 		"node_modules/**"