提交 54da36d1 编写于 作者: J Johannes Rieken

proper disposing of outline objects

上级 d7644dc2
......@@ -206,6 +206,7 @@ class NotebookCellOutline implements IOutline<OutlineEntry> {
dispose(): void {
this._dispoables.dispose();
this._entriesDisposables.dispose();
}
private _recomputeState(): void {
......
......@@ -123,6 +123,8 @@ export class OutlinePane extends ViewPane {
if (!visible) {
// stop everything when not visible
this._editorListener.clear();
this._editorDisposables.clear();
} else if (!this._editorListener.value) {
this._editorListener.value = Event.any(this._editorService.onDidActiveEditorChange, this._outlineService.onDidChange)(() => {
this._handleEditorChanged(this._editorService.activeEditorPane);
......@@ -201,6 +203,7 @@ export class OutlinePane extends ViewPane {
return;
}
this._editorDisposables.add(newOutline);
this._progressBar.stop().hide();
const tree = <WorkbenchDataTree<IOutline<any>, any, FuzzyScore>>this._instantiationService.createInstance(
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册