Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
504c890e
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
504c890e
编写于
9月 06, 2018
作者:
J
Johannes Rieken
提交者:
GitHub
9月 06, 2018
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #57974 from Microsoft/rmacfarlane/winjspromise
Remove usage of asWinJSPromise from comment service, #56137
上级
44dc55b9
f75813b4
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
11 addition
and
12 deletion
+11
-12
src/vs/workbench/parts/comments/electron-browser/commentService.ts
...rkbench/parts/comments/electron-browser/commentService.ts
+11
-12
未找到文件。
src/vs/workbench/parts/comments/electron-browser/commentService.ts
浏览文件 @
504c890e
...
...
@@ -11,9 +11,8 @@ import { Event, Emitter } from 'vs/base/common/event';
import
{
Disposable
}
from
'
vs/base/common/lifecycle
'
;
import
{
URI
}
from
'
vs/base/common/uri
'
;
import
{
Range
}
from
'
vs/editor/common/core/range
'
;
import
{
TPromise
}
from
'
vs/base/common/winjs.base
'
;
import
{
asWinJsPromise
}
from
'
vs/base/common/async
'
;
import
{
keys
}
from
'
vs/base/common/map
'
;
import
{
CancellationToken
}
from
'
vs/base/common/cancellation
'
;
export
const
ICommentService
=
createDecorator
<
ICommentService
>
(
'
commentService
'
);
...
...
@@ -40,9 +39,9 @@ export interface ICommentService {
registerDataProvider
(
owner
:
number
,
commentProvider
:
DocumentCommentProvider
):
void
;
unregisterDataProvider
(
owner
:
number
):
void
;
updateComments
(
event
:
CommentThreadChangedEvent
):
void
;
createNewCommentThread
(
owner
:
number
,
resource
:
URI
,
range
:
Range
,
text
:
string
):
T
Promise
<
CommentThread
>
;
replyToCommentThread
(
owner
:
number
,
resource
:
URI
,
range
:
Range
,
thread
:
CommentThread
,
text
:
string
):
T
Promise
<
CommentThread
>
;
getComments
(
resource
:
URI
):
T
Promise
<
CommentInfo
[]
>
;
createNewCommentThread
(
owner
:
number
,
resource
:
URI
,
range
:
Range
,
text
:
string
):
Promise
<
CommentThread
>
;
replyToCommentThread
(
owner
:
number
,
resource
:
URI
,
range
:
Range
,
thread
:
CommentThread
,
text
:
string
):
Promise
<
CommentThread
>
;
getComments
(
resource
:
URI
):
Promise
<
CommentInfo
[]
>
;
}
export
class
CommentService
extends
Disposable
implements
ICommentService
{
...
...
@@ -95,35 +94,35 @@ export class CommentService extends Disposable implements ICommentService {
this
.
_onDidUpdateCommentThreads
.
fire
(
event
);
}
createNewCommentThread
(
owner
:
number
,
resource
:
URI
,
range
:
Range
,
text
:
string
):
T
Promise
<
CommentThread
>
{
createNewCommentThread
(
owner
:
number
,
resource
:
URI
,
range
:
Range
,
text
:
string
):
Promise
<
CommentThread
>
{
const
commentProvider
=
this
.
_commentProviders
.
get
(
owner
);
if
(
commentProvider
)
{
return
asWinJsPromise
(
token
=>
commentProvider
.
createNewCommentThread
(
resource
,
range
,
text
,
token
)
);
return
commentProvider
.
createNewCommentThread
(
resource
,
range
,
text
,
CancellationToken
.
None
);
}
return
null
;
}
replyToCommentThread
(
owner
:
number
,
resource
:
URI
,
range
:
Range
,
thread
:
CommentThread
,
text
:
string
):
T
Promise
<
CommentThread
>
{
replyToCommentThread
(
owner
:
number
,
resource
:
URI
,
range
:
Range
,
thread
:
CommentThread
,
text
:
string
):
Promise
<
CommentThread
>
{
const
commentProvider
=
this
.
_commentProviders
.
get
(
owner
);
if
(
commentProvider
)
{
return
asWinJsPromise
(
token
=>
commentProvider
.
replyToCommentThread
(
resource
,
range
,
thread
,
text
,
token
)
);
return
commentProvider
.
replyToCommentThread
(
resource
,
range
,
thread
,
text
,
CancellationToken
.
None
);
}
return
null
;
}
getComments
(
resource
:
URI
):
T
Promise
<
CommentInfo
[]
>
{
getComments
(
resource
:
URI
):
Promise
<
CommentInfo
[]
>
{
const
result
=
[];
for
(
const
handle
of
keys
(
this
.
_commentProviders
))
{
const
provider
=
this
.
_commentProviders
.
get
(
handle
);
if
((
<
DocumentCommentProvider
>
provider
).
provideDocumentComments
)
{
result
.
push
(
asWinJsPromise
(
token
=>
(
<
DocumentCommentProvider
>
provider
).
provideDocumentComments
(
resource
,
token
)
));
result
.
push
(
(
<
DocumentCommentProvider
>
provider
).
provideDocumentComments
(
resource
,
CancellationToken
.
None
));
}
}
return
TPromise
.
join
(
result
);
return
Promise
.
all
(
result
);
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录