propagate ext terminal errrors; fixes #92380

src/vs/workbench/api/browser/mainThreadDebugService.ts

@@ -75,7 +75,7 @@ export class MainThreadDebugService implements MainThreadDebugServiceShape, IDeb
 	}
 
 	runInTerminal(args: DebugProtocol.RunInTerminalRequestArguments): Promise<number | undefined> {
-		return Promise.resolve(this._proxy.$runInTerminal(args));
+		return this._proxy.$runInTerminal(args);
 	}
 
 	// RPC methods (MainThreadDebugServiceShape)

src/vs/workbench/api/node/extHostDebugService.ts

@@ -113,7 +113,7 @@ export class ExtHostDebugService extends ExtHostDebugServiceBase {
 
 		} else if (args.kind === 'external') {
 
-			runInExternalTerminal(args, await this._configurationService.getConfigProvider());
+			return runInExternalTerminal(args, await this._configurationService.getConfigProvider());
 		}
 		return super.$runInTerminal(args);
 	}

src/vs/workbench/contrib/debug/node/terminals.ts

@@ -12,7 +12,7 @@ import { ExtHostConfigProvider } from 'vs/workbench/api/common/extHostConfigurat
 
 let externalTerminalService: IExternalTerminalService | undefined = undefined;
 
-export function runInExternalTerminal(args: DebugProtocol.RunInTerminalRequestArguments, configProvider: ExtHostConfigProvider): void {
+export function runInExternalTerminal(args: DebugProtocol.RunInTerminalRequestArguments, configProvider: ExtHostConfigProvider): Promise<number | undefined> {
 	if (!externalTerminalService) {
 		if (env.isWindows) {
 			externalTerminalService = new WindowsExternalTerminalService(<IConfigurationService><unknown>undefined);
@@ -20,12 +20,12 @@ export function runInExternalTerminal(args: DebugProtocol.RunInTerminalRequestAr
 			externalTerminalService = new MacExternalTerminalService(<IConfigurationService><unknown>undefined);
 		} else if (env.isLinux) {
 			externalTerminalService = new LinuxExternalTerminalService(<IConfigurationService><unknown>undefined);
+		} else {
+			throw new Error('external terminals not supported on this platform');
 		}
 	}
-	if (externalTerminalService) {
-		const config = configProvider.getConfiguration('terminal');
-		externalTerminalService.runInTerminal(args.title!, args.cwd, args.args, args.env || {}, config.external || {});
-	}
+	const config = configProvider.getConfiguration('terminal');
+	return externalTerminalService.runInTerminal(args.title!, args.cwd, args.args, args.env || {}, config.external || {});
 }
 
 function spawnAsPromised(command: string, args: string[]): Promise<string> {