提交 4c51b89d 编写于 作者: D Daniel Imms

Remove TerminalLink.target

Part of #91290
上级 6d6edefd
...@@ -1075,14 +1075,16 @@ declare module 'vscode' { ...@@ -1075,14 +1075,16 @@ declare module 'vscode' {
} }
export interface TerminalLinkProvider<T = TerminalLink> { export interface TerminalLinkProvider<T = TerminalLink> {
/**
* Provide terminal links for the given context.
* @param context Information about what links are being provided for.
*/
provideTerminalLinks(context: TerminalLinkContext): ProviderResult<T[]> provideTerminalLinks(context: TerminalLinkContext): ProviderResult<T[]>
/** /**
* Handle an activated terminal link. * Handle an activated terminal link.
*
* @returns Whether the link was handled, if not VS Code will attempt to open it.
*/ */
handleTerminalLink(link: T): ProviderResult<boolean>; handleTerminalLink(link: T): void;
} }
export interface TerminalLink { export interface TerminalLink {
...@@ -1096,12 +1098,6 @@ declare module 'vscode' { ...@@ -1096,12 +1098,6 @@ declare module 'vscode' {
*/ */
length: number; length: number;
/**
* The uri this link points to. If set, and {@link TerminalLinkProvider.handlerTerminalLink}
* is not implemented or returns false, then VS Code will try to open the Uri.
*/
target?: Uri;
/** /**
* The tooltip text when you hover over this link. * The tooltip text when you hover over this link.
* *
......
...@@ -651,9 +651,6 @@ export abstract class BaseExtHostTerminalService implements IExtHostTerminalServ ...@@ -651,9 +651,6 @@ export abstract class BaseExtHostTerminalService implements IExtHostTerminalServ
return; return;
} }
cachedLink.provider.handleTerminalLink(cachedLink.link); cachedLink.provider.handleTerminalLink(cachedLink.link);
// TODO: Handle when result is false? Should this be return void instead and remove
// TerminalLink.target? It's a simple call to window.openUri for the extension otherwise
// and would simplify the API.
} }
private _onProcessExit(id: number, exitCode: number | undefined): void { private _onProcessExit(id: number, exitCode: number | undefined): void {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册